docs: link source field to S3 access operator notes - #2251
Conversation
Signed-off-by: Deepak Bhagat <deepak988088@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (2)config/**⚙️ CodeRabbit configuration file
Files:
docs/**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (9)
📝 WalkthroughWalkthroughConfiguration schema and versioned documentation now include AWS S3 URL formats, access references, and credential-resolution guidance for remote configuration, certificate, file, fragment, and LUKS key-file sources. ChangesAWS S3 source documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The
sourcefield listss3andarnas supported schemes but says nothing about how S3 credentials are handled. Someone writing a config withsource: s3://...has no pointer to how authentication works. This came up in coreos/butane#662, where the reporter noted the Butane spec docs, which are generated from this schema, are silent on S3 credentials.This adds a sentence to the
sourcedescription inconfig/doc/ignition.yamlpointing at the AWS S3 access operator notes. That page already documents the supported URL formats (s3://andarn:...) and how credentials get resolved: the instance IAM role inside EC2, anonymous otherwise. A maintainer suggested fixing it here first so Butane picks it up on the next vendor bump.I regenerated the versioned docs with the doc generator. The sentence lands on every
sourcefield across all specs. Older specs keep their reduced scheme list (s3only before 3.2.0, noarnbefore 3.4.0) because the version transforms are left untouched.Addresses coreos/butane#662