docs: link source field to AWS S3 access operator notes - #2288
Conversation
The `source` field description lists `s3` and `arn` as supported schemes but says nothing about how credentials are resolved at runtime. Add a pointer to Ignition's AWS S3 access operator notes, which document the supported URL formats and credential resolution. This bridges the schema docs and runtime behavior for S3 sources, as requested in coreos/butane#662. Fixes coreos/butane#662 Signed-off-by: Deepak Bhagat <deepak988088@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (1)config/**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe resource source description now documents supported AWS S3 and ARN URL formats and links to Ignition’s AWS S3 access documentation. ChangesSource URL documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation update adds the missing AWS S3 credential-resolution reference without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing in favor of #2251, which does the same thing but correctly. Both PRs add the pointer to the AWS S3 access operator notes in config/doc/ignition.yaml. The difference is what ships to the docs site:
Keeping the one that lands the change end to end. Thanks for the quick review on the earlier version. |
Issue
coreos/butane#662 — the
sourcefield docs lists3/arnas supported schemes but are silent on how S3 credentials are resolved at runtime.Approach
As agreed with @pabo99 / @prestist in the issue thread, the fix belongs upstream in Ignition's
config/doc/ignition.yaml(Butane's spec docs are generated from this file, and the butane and ignition repos are now merged). Thesourcefield description now links to Ignition's AWS S3 access operator notes, which document the supporteds3:///arn:...URL formats and credential resolution.This follows the existing pattern used by other fields that link to
operator-notes/#...(e.g. the filesystem wipe descriptions).Verification
config/doc/ignition.yamlandbutane/internal/doc/butane.yamlparse as valid YAML.sourcetransform (a full-replacement regex ending at "haven't been modified.") is unaffected — it still replaces the whole description with "Only thedatascheme is supported." for openshift, which remains correct.Fixes coreos/butane#662