docs: add file append and overwrite examples - #729
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded file-storage examples that show how ChangesFile storage documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This documentation-only change adds examples for file append and overwrite behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/examples.md`:
- Around line 152-166: Update the documentation example using the append
configuration to target /etc/sudoers as requested by Issue `#499`, or add a
separate /etc/sudoers example while retaining the existing /etc/sudoers.d/core
drop-in example if intentional. Keep the append behavior and overwrite: false
defaults unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Good catch — the drop-in example didn't actually answer #499, which asked for an example appending to Pushed |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/examples.md`:
- Around line 162-164: Restrict the Podman sudoers examples so they do not
present unrestricted passwordless root access: update the rule at
docs/examples.md lines 162-164 and the corresponding drop-in example at lines
178-180 with a bounded command and explicit arguments, or add a clear warning
that each rule grants root-equivalent access.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Hey @JasonColapietro Thanks for the PR! We’re archiving this repository as Butane is being merged into Ignition, so new changes should now go to Ignition: We already created a new issue for this in ignition's repo: coreos/ignition#2270 You’re very welcome to reopen this work there and I will be glad to review. Thank you for contributing! |
|
Thanks @yasminvalim — moved it over to coreos/ignition#2302, which ports these examples to Closing this one. |
Summary
appendexample using explicitoverwrite: false/etc/sudoersand the preferred/etc/sudoers.d/drop-in formcontentsexample usingoverwrite: trueTesting
./test(passes; its docs loop reports that it is skipped on macOS when GNUcsplitandheadare unavailable)--check --strictgit diff --checkCloses #499.