Skip to content

test/kubernetes: use zero-value TextParser until prometheus/common is bumped #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test/kubernetes: use zero-value TextParser until prometheus/common is bumped #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test/kubernetes/metrics_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (

dto "github.com/prometheus/client_model/go"
"github.com/prometheus/common/expfmt"
"github.com/prometheus/common/model"
api "k8s.io/api/core/v1"
discovery "k8s.io/api/discovery/v1"
meta "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down Expand Up @@ -85,7 +84,11 @@ func testEndpoints(t *testing.T, client *kubernetes.Clientset, slices bool) {

// scrape and parse metrics to get base state
m := ScrapeMetrics(t)
tp := expfmt.NewTextParser(model.LegacyValidation)
// prometheus/common v0.59.1 (pinned in go.mod) does not yet expose
// NewTextParser; stick with the zero-value TextParser, which
// defaults to legacy validation, until coredns/coredns#7731 bumps
// the common dep.
var tp expfmt.TextParser
base, err := tp.TextToMetricFamilies(strings.NewReader(string(m)))
if err != nil {
t.Fatalf("Could not parse scraped metrics: %v", err)
Expand Down