test/kubernetes: use zero-value TextParser until prometheus/common is bumped#175
Open
SAY-5 wants to merge 1 commit intocoredns:masterfrom
Open
test/kubernetes: use zero-value TextParser until prometheus/common is bumped#175SAY-5 wants to merge 1 commit intocoredns:masterfrom
SAY-5 wants to merge 1 commit intocoredns:masterfrom
Conversation
… bumped expfmt.NewTextParser was introduced in a later prometheus/common release than the one pinned here (v0.59.1), so every CoreDNS PR that runs the Kubernetes test step fails with: ./metrics_test.go:87:15: undefined: expfmt.NewTextParser Revert that call site to the zero-value `var tp expfmt.TextParser` pattern (which defaults to legacy validation) so the job compiles on the currently pinned dependency. Once go.mod's prometheus/ common is bumped to a version that exports NewTextParser (see coredns/coredns#7731), this can be re-applied without the compat note. Also drop the now-unused prometheus/common/model import. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Author
|
The five |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
expfmt.NewTextParserwas introduced in a laterprometheus/commonrelease than the one pinned here (v0.59.1), so every CoreDNS PR that runs the Kubernetes test step fails with:(reported against coredns/coredns#7731 - e.g. the Circle-CI failure on coredns/coredns#7728).
Revert that call site to the zero-value
var tp expfmt.TextParserpattern (which defaults to legacy validation) so the job compiles on the currently pinned dependency. Oncego.mod'sprometheus/commonis bumped to a version that exportsNewTextParser, this can be re-applied without the compat note.Also drops the now-unused
prometheus/common/modelimport.Release note: