CPBR-3961 | Fix Broken Local Docker Build Command in base-java - #2154
Open
Swayam Prakash Kar (swkar-conf) wants to merge 3 commits into
Open
CPBR-3961 | Fix Broken Local Docker Build Command in base-java#2154Swayam Prakash Kar (swkar-conf) wants to merge 3 commits into
Swayam Prakash Kar (swkar-conf) wants to merge 3 commits into
Conversation
-Pdocker alone doesn't pin the io.fabric8:docker-maven-plugin version, so mvn clean package -Pdocker -DskipTests hangs resolving it. Swap in the jenkins,docker-fabric8 profile combination CI actually uses. (CPBR-3947)
Copilot started reviewing on behalf of
Swayam Prakash Kar (swkar-conf)
July 24, 2026 05:05
View session
There was a problem hiding this comment.
⚠️ Not ready to approve
The updated README build command depends on an undocumented environment variable ($DOCKER_DEV_REGISTRY), making the copy/paste instruction potentially incorrect for typical local use.
Pull request overview
Updates the base-java documentation to reflect the Maven profile combination used in CI, addressing a reported hang when building local Docker images with -Pdocker alone.
Changes:
- Replaced the README’s local build command with the CI-aligned Maven invocation using
jenkins,docker-fabric8. - Added a brief explanation for why the profile combination is required and linked to the Semaphore CI config for reference.
File summaries
| File | Description |
|---|---|
| base-java/README.md | Updates local build instructions and explains the CI profile combination used to avoid fabric8 plugin resolution issues. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ild command Copilot review caught it: the var is never introduced in this doc and expands to empty for most readers, contradicting the earlier trailing-slash requirement. Omitting it uses Maven's placeholder/ default, confirmed working locally. (CPBR-3947)
Swayam Prakash Kar (swkar-conf)
changed the title
Mihir Chandna (mihirchandna)
left a comment
Mihir Chandna (mihirchandna)
left a comment
Member
There was a problem hiding this comment.
cp-base-java-micro also has this same command, did we verify that?
CI flags (--batch-mode, retry handler, dependency:analyze) don't belong in a local dev command, and dropping -DskipTests defeats the point of a quick local build. -P docker-fabric8 alone (no jenkins profile) already pins the fabric8 plugin version correctly, confirmed locally, same as Mihir suggested. Updated the explanatory line to match. (CPBR-3961)
Swayam Prakash Kar (swkar-conf)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
mvn clean package -Pdocker -DskipTestshangs resolvingio.fabric8:docker-maven-plugin, because-Pdockeralone doesn't pin its version. This PR switches to-P docker-fabric8instead, in both base-java and base-java-micro since they carried the same line.Ref: https://confluentinc.atlassian.net/browse/CPBR-3961
Testing
Ran
mvn clean package -P docker-fabric8 -DskipTestslocally. The plugin resolves and the build proceeds, then stops on an unrelated pre-existing gap (log4j:1.2.12isn't in any configured repo, so checkstyle can't resolve).-Pdockeralone, the bug:Plugin not found in any plugin repository: io.fabric8:docker-maven-plugin, thenBUILD FAILURE.With the fabric8 profile, no plugin-not-found error. These two were captured with the fuller CI form of the command, before review trimmed it to
-P docker-fabric8 -DskipTests, but the plugin resolution being fixed is the same.Gets past plugin metadata resolution into real build steps (
clean:3.1.0:clean,buildnumber:1.4:create). The 401 warnings above that point are pre-existing and unrelated.