bdev/rbd: integrate SpdkContextWQ for reactor thread execution#17
Open
baum wants to merge 2 commits into
Open
Conversation
baum
force-pushed
the
librbd_asio_spdk
branch
2 times, most recently
from
08f907b to
8ad5a1a
Compare
gbregman
force-pushed
the
ceph-nvmeof-v25.09
branch
2 times, most recently
from
7c7026c to
289d473
Compare
baum
force-pushed
the
librbd_asio_spdk
branch
from
040222b to
b532f5f
Compare
gbregman
force-pushed
the
ceph-nvmeof-v25.09
branch
3 times, most recently
from
c3ea327 to
912f5f1
Compare
14 tasks
baum
force-pushed
the
librbd_asio_spdk
branch
4 times, most recently
from
0b88e4c to
3ad6e64
Compare
gbregman
force-pushed
the
ceph-nvmeof-v25.09
branch
3 times, most recently
from
60b5c24 to
cf59213
Compare
Signed-off-by: Gil Bregman <gbregman@il.ibm.com> (cherry picked from commit cf59213) Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
baum
force-pushed
the
librbd_asio_spdk
branch
2 times, most recently
from
f5fa24a to
d64385e
Compare
baum
force-pushed
the
librbd_asio_spdk
branch
4 times, most recently
from
61de874 to
7944465
Compare
Add SpdkContextWQ implementation to schedule RBD I/O operations on SPDK reactor threads instead of ASIO thread pool. This includes: Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
gbregman
force-pushed
the
ceph-nvmeof-v26.01
branch
3 times, most recently
from
fb9ebd9 to
f373386
Compare
gbregman
force-pushed
the
ceph-nvmeof-v26.01
branch
from
e287537 to
a98c167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Schedule librbd async completions on SPDK reactor threads instead of the librados ASIO pool when the NVMe-oF gateway enables
rbd_with_spdk_wq.Problem: With default
AsioContextWQ, librbd completions contend on theio_contextpool; at scale (64 namespaces, high iodepth) throughput collapses. Delivering work only viaspdk_thread_send_msg()also bottlenecks on SPDK's shared message mempool.Solution:
SpdkContextWQimplements the CephContextWQabstract base class and binds each RBD bdev to a reactor (round-robin). Hot-path work uses a per-reactor MP/SC ring drained by an SPDK poller;spdk_thread_send_msg()remains as fallback when the ring is full. Supporting changes inlib/thread/thread.csimplify the per-threadspdk_msgcache.Changes
SpdkContextWQ—post/dispatch/post_serial/dispatch_serial/drain; inherits defaultqueue()bdev_rbd_spdk_context_wq.cpp)bdev_rbd_set_with_spdk_wq,bdev_rbd_get_with_spdk_wqrbd_open_with_context_wq()frombdev_rbd.cRelated PRs