integration branch for librbd_asio_spdk

[baum]

integration branch for librbd_asio_spdk

• SPDK PR bdev/rbd: integrate SpdkContextWQ for reactor thread execution spdk#17
• CEPH-CI https://github.com/ceph/ceph-ci/tree/librbd_asio_spdk
• ceph PR librbd: expose ContextWQ as an abstract base class in the public API for external implementations ceph#66881

[Copilot]

Pull request overview

Integrates support for configuring and testing RBD SPDK ContextWQ usage in the NVMe-oF gateway/SPDK test pipeline.

Changes:

• Add SPDK ContextWQ configuration initialization in the control plane.
• Introduce a dedicated HA startup script and config for the spdk_wq test variant.
• Extend GitHub Actions test matrix to run the new spdk_wq scenario and pin Ceph branch accordingly.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/ha/start_up_spdk_wq.sh	New HA startup wrapper that sets NVMEOF_CONFIG for the SPDK WQ scenario
tests/ha/spdk_wq.sh	New test entry for the spdk_wq workflow matrix
tests/ceph-nvmeof.spdk_wq.conf	New config enabling rbd_with_spdk_wq for CI/testing
spdk	Updates SPDK submodule pointer
control/server.py	Initializes SPDK RPC setting for rbd_with_spdk_wq during SPDK startup
ceph-nvmeof.conf	Documents the new rbd_with_spdk_wq option
.github/workflows/build-container.yml	Adds spdk_wq to CI test matrix
.env	Pins Ceph branch to librbd_asio_spdk for this integration

Comments suppressed due to low confidence (1)

tests/ha/spdk_wq.sh:1

• As a .sh file, this will be executed by the test harness/CI, but it has no shebang and calls sanity.sh without a path; it will fail unless the current working directory happens to contain sanity.sh and it’s resolvable via PATH. Make this an explicit wrapper script (with a shebang) that invokes the intended script via a stable path (e.g., relative to $(dirname "$0")), or replace this file with a symlink if the harness supports it.

set -xe

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

tests/ha/spdk_wq.sh:1

• tests/ha/spdk_wq.sh is being added as a test entry point but it contains only sanity.sh and has no shebang. If CI executes it directly (common pattern with ./tests/ha/${test}.sh), this will fail (exec format error) or behave unexpectedly. Make it an actual shell script with a shebang and invoke the intended script explicitly (e.g., exec ./sanity.sh or exec \"$test_dir/sanity.sh\" depending on how other HA tests are structured), or convert it into a symlink if the harness supports that.

set -xe

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

tests/ha/spdk_wq.sh:1

• As written, this file is not a valid executable script (no shebang) and will only work if invoked by an existing shell and if sanity.sh is discoverable in PATH. If the intent is to run the sibling sanity.sh, make this a proper wrapper script with a shebang and invoke the target via a relative path (so it works regardless of PATH/CWD).

set -xe

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

tests/ha/start_up_spdk_wq.sh:13

• NVMEOF_CONFIG is set to a relative path (./tests/...) that depends on the caller’s current working directory. This script computes test_dir, but doesn’t use it for NVMEOF_CONFIG, so running the script from outside the repo root will point Docker Compose at a non-existent config. Consider deriving NVMEOF_CONFIG from $GITHUB_WORKSPACE (when set) or from test_dir/its parent directory.

if [ -n "$GITHUB_WORKSPACE" ]; then
    test_dir="$GITHUB_WORKSPACE/tests/ha"
else
    test_dir=$(dirname $0)
fi

export NVMEOF_CONFIG=./tests/ceph-nvmeof.spdk_wq.conf
$test_dir/start_up.sh

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.