e2e-tests: Add tests for allowed_users broker property#1469
Open
nooreldeenmansour wants to merge 5 commits intomainfrom
Open
e2e-tests: Add tests for allowed_users broker property#1469nooreldeenmansour wants to merge 5 commits intomainfrom
allowed_users broker property#1469nooreldeenmansour wants to merge 5 commits intomainfrom
Conversation
nooreldeenmansour
changed the title
allowed_users broker config propertyallowed_users broker property
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
+ Coverage 80.48% 86.94% +6.46%
==========================================
Files 20 93 +73
Lines 1030 6366 +5336
Branches 0 111 +111
==========================================
+ Hits 829 5535 +4706
- Misses 201 775 +574
- Partials 0 56 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nooreldeenmansour
force-pushed
the
e2e-tests-allowed-users
branch
2 times, most recently
from
3a25d0d to
5034c2d
Compare
Member
Author
|
Any idea why the provisioning ci jobs are failing? This my third time doing a force push to trigger CI |
Contributor
The Ubuntu archive is having issues today |
Contributor
nooreldeenmansour
force-pushed
the
e2e-tests-allowed-users
branch
2 times, most recently
from
b07f13c to
caf67c7
Compare
Member
Author
|
The archive is operational now, but the CI jobs is failing because the broker snaps are failing to build. Probably related to #1470 |
Test that a user set as broker owner can log in successfully when `allowed_users` is configured to `OWNER `and the configuration remains unchanged after login
Test that login fails with permission denied when `allowed_users` is set to `OWNER` but `owner` is explicitly set to an empty value, since no user can match an empty owner.
nooreldeenmansour
force-pushed
the
e2e-tests-allowed-users
branch
from
caf67c7 to
43b8492
Compare
Test that a remote user can log in successfully when `allowed_users` is configured to `ALL` and the configuration remains unchanged after login.
Test that a remote user can log in successfully when `allowed_users` is configured to the user name used for login and the configuration remains unchanged after login.
Test that login fails with permission denied when `allowed_users` is set to a different user than the one attempting to log in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for the following scenarios:
allowed_usersis set toOWNERand theowneris set to the test user (login successful)allowed_usersis set toOWNERandowneris explicitly set to an empty value (login denied)allowed_usersis set touserand login with that user (login successful)allowed_usersset to a specific user and login with a different user (login denied)allowed_usersis set to toALL(login successful)UDENG-9543
UDENG-9544
UDENG-9545
UDENG-9546
UDENG-9547