Skip to content

Fix issue 1594 (test_add_timeout leaks a 1-second timeout into the shared client) #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoineeripret merged 1 commit into from
Jul 16, 2026
Merged

Fix issue 1594 (test_add_timeout leaks a 1-second timeout into the shared client) #1595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/client_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,10 @@ def test_add_timeout(self):
# Once recorded it takes 0.001 seconds to run it, so 1 second should be a large enough value
timeout = 1
self.gc.set_timeout(timeout)
# the client fixture is module-scoped, restore the default timeout so it
# does not leak into the tests that run after this one
# this fixes issue #1594
self.addCleanup(self.gc.set_timeout, None)
start = time.time()
self.spreadsheet.fetch_sheet_metadata()
end = time.time()
Expand Down
Loading