Fix issue 1594 (test_add_timeout leaks a 1-second timeout into the shared client) - #1595
Merged
Merged
Conversation
Restore the default timeout when the test test_add_timeout finishes, so it cannot leak into the shared client
janmarsino98
approved these changes
Jul 14, 2026
janmarsino98
left a comment
janmarsino98
left a comment
There was a problem hiding this comment.
Reviewed the module-scoped client fixture and ran the modified test successfully. addCleanup is registered immediately after set_timeout, so the default is restored even when the test fails later. No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the default timeout when the test test_add_timeout finishes, so it cannot leak into the shared client.
This fixes this issue #1594
After this change all online tests passed for me.