Replace dogstatsd metrics with opentelemetry metrics (take 2)#4025
Merged
Conversation
DrJosh9000
added
v4
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
DrJosh9000
changed the title
CerealBoy
approved these changes
Jun 24, 2026
CerealBoy
left a comment
CerealBoy
left a comment
Member
There was a problem hiding this comment.
One tiny question, LGTM 🚀 🚀
|
|
||
| if exit.Status == 0 { | ||
| jobMetrics.Timing("jobs.duration.success", finishedAt.Sub(r.startedAt)) | ||
| jobMetrics.Count("jobs.success", 1) |
Member
There was a problem hiding this comment.
Did we still want a success / failed metric here?
Contributor
Author
There was a problem hiding this comment.
#3874 specifically included in the changes:
Replaces the jobs.success and jobs.failed counters with jobs.finished — failure or success can be inferred with the exit_status tag that's applied to the metric
Contributor
Author
|
I think I left off two commits. One sec... |
moskyb
approved these changes
Jun 24, 2026
| &cli.StringFlag{ | ||
| Name: "tracing-service-name", | ||
| Usage: "Service name to use when reporting traces.", | ||
| Usage: "Service name to use when reporting telemetry.", |
Contributor
There was a problem hiding this comment.
should the flag also change to telemetry-service-name?'
Contributor
Author
There was a problem hiding this comment.
Done, including the env var
DrJosh9000
force-pushed
the
opentel-metrics-take-2
branch
2 times, most recently
from
a3cd613 to
eec4c75
Compare
DrJosh9000
force-pushed
the
opentel-metrics-take-2
branch
from
eec4c75 to
df7e0af
Compare
DrJosh9000
added a commit
that referenced
this pull request
Jun 24, 2026
Replace dogstatsd metrics with opentelemetry metrics (take 2)
DrJosh9000
added a commit
that referenced
this pull request
Jun 24, 2026
Replace dogstatsd metrics with opentelemetry metrics (take 2)
DrJosh9000
added a commit
that referenced
this pull request
Jun 24, 2026
Replace dogstatsd metrics with opentelemetry metrics (take 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From #3874:
Context
Closes #3874
@moskyb:
Changes
#3874 but rebased onto current v4. (I've been repeatedly rebasing v4 onto main during this time.)
--tracing-service-nameto--telemetry-service-name/BUILDKITE_TRACING_SERVICE_NAMEtoBUILDKITE_TELEMETRY_SERVICE_NAMETesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
All the good work @moskyb did in #3874