Repository navigation
Release identity search recovery with SDK 3.2 - #17
Merged
Merged
Conversation
ty-everett
marked this pull request as ready for review
October 7, 2026 03:11
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
sirdeggen
approved these changes
Oct 7, 2026
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identity searches currently treat Contacts failures as empty answers and retain stale results across requests or wallet contexts. Version 2 adopts the published SDK 3.2.0 recovery API: optional Contacts are bounded at two seconds, partial results show a warning, public failures show a retry action, and only complete results enter a per-hook/context cache. Late results cannot replace a newer query or selection.
This major release requires React18 and Node22 tooling with a browser bundler; SDK3 serial-DID retirement has separate migration guidance. Existing selection APIs, BRC100 wire, wallet permissions and storage remain unchanged. Named MUI icon exports fix packed ESM browser rendering. The master workflow qualifies Node22/24 and publishes the exact retained tarball through npm OIDC with provenance.
Validation: frozen registry SDK3.2 install; formatting, TypeScript, build, 27 search/component/integration regressions; packed browser component render contract with an original-icon negative control; audit and registry signatures. Local wallet browser checks covered successful public lookup/selection, synthetic denied/pending Contacts, contact-only fixtures, public failure and retry. Deadlines do not cancel wallet prompts; no payment was sent.
Exact reviewed head:
ce7a9015e5e547542461d9b6488b6c2d23a40897. Node22/24 qualification37565541774 and CodeQL37565538335 succeeded; only master-only publication is expected to skip on this PR. No unresolved review threads or open CodeQL alerts.The CI-qualified tarball is byte identical to the locally tested final candidate: SHA256
381008fff2373f2bab87338ecc16b4ef6aede93d6c90371e52423c4e90b8cb45; npm integritysha512-+vsAmOn06a5s5LP5IoQyN1nF8Qj93my82CM3Jfm1vjU01B4Pe64Jbb7TkH0t1IZgD98mv9jDPzNDaLUsjwyGIw==. PeerPay's final uninstrumented production bundle using this candidate and published SDK3.2.0 passes19 tests/typecheck/build and public identity lookup/selection through Metanet Desktop0.8.10. Candidate publication and the PeerPay frozen registry lockfile remain pending.Merge is waiting for the repository's required approving review from another write-access account. The author's maintain role cannot bypass that rule; protections remain intact.