Repository navigation
Conversation
Bump the SDK to 3.2.0 and the wallet and message-box clients to releases that accept SDK 3. Show optional Contacts lookups with a 2s deadline, the partial-result warning, public lookup retry, and complete-result caching. Co-authored-by: deggen <d.kellenschwiler@bsvassociation.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review by @sirdeggen. Do not merge from this change.
Summary
@bsv/sdkfrom^2.8.11to^3.2.0.@bsv/wallet-toolbox-clientto^2.14.6and@bsv/message-box-clientto^2.6.0, the current releases whose peers accept SDK 3.public/llm-training-guide.txtto the SDK 3.2.0 identity search recovery API used by identity-react#17.Identity search recovery
resolveByAttributesandresolveByIdentityKeynow opt in with{ useContacts: true }. Contacts lookups stay optional.contactErrorMode: 'fallback'andcontactTimeoutMs: 2000bound that wait at 2 seconds; the deadline does not cancel a wallet prompt.A Contacts failure or timeout still returns public results and surfaces
Saved contacts are unavailable. Results may exclude saved contacts.A public lookup failure stays a failure (Identity lookup failed. Check wallet access and try again.) untilretryResolveIdentityKey/retryResolveKnownIdentityKeyrepeats the same query. Only complete results are cached. A newer query ignores a late response from the one it superseded.React apps can use
@bsv/identity-react2.x (React 18, Node 22) for the same recovery behavior.Verification
npm test(74 tests)npm run typechecknpm run lint(existing warnings only)npm run buildnpm run build:snippets/?topic=identity: SDK v3 subtitle, both identity cards, the warning string, and the recovery options in the shown code.