Quit Application on any RenderErrors by default

_release-content/release-notes/render-recovery.md

@@ -1,7 +1,7 @@
 ---
 title: "Render Recovery"
 authors: ["@atlv24"]
-pull_requests: [22761, 23350, 23349, 23433, 23458, 23444, 23459, 23461, 23463, 22714, 22759, 16481]
+pull_requests: [22761, 23350, 23349, 23433, 23458, 23444, 23459, 23461, 23463, 22714, 22759, 16481, 24131]
 --- 
 
 You can now recover from rendering errors such as device loss by reloading the renderer:
@@ -21,4 +21,4 @@ app.insert_resource(RenderErrorHandler(
 
 NOTE: this is just an example showing the different errors and policies available, and not a recommendation for how to handle errors.
 
-The default error handler behaves identically to how Bevy behaved before: validation errors are ignored, and other errors crash/hang the application.
+The default error handler will quit the application on any RenderError.

crates/bevy_render/src/error_handler.rs

@@ -1,4 +1,5 @@
 use alloc::sync::Arc;
+use bevy_app::AppExit;
 use bevy_ecs::{
     resource::Resource,
     world::{Mut, World},
@@ -19,13 +20,22 @@ use crate::{
 pub enum RenderErrorPolicy {
     /// Pretends nothing happened and continues rendering.
     /// This discards the error after logging it to console.
+    /// WARNING: Using this policy can cause hazardous rapid flashing
+    /// if the conditions causing the error remain unaddressed, since
+    /// rendering will attempt to continue executing.
+    /// When choosing to use this policy, be sure to test that the application
+    /// remains safe to use.
     Ignore,
     /// Keeps the app alive, but stops rendering further.
     /// This keeps the error state, and will continue polling the [`RenderErrorHandler`]
     /// every frame until some other policy is returned.
     StopRendering,
     /// Attempt renderer recovery with the given [`RenderCreation`].
     Recover(RenderCreation),
+    /// Quits the app.
+    /// This stops rendering and sends an [`AppExit::error`], which will
+    /// immediately terminate the app.
+    QuitApplication,
 }
 
 /// Determines what [`RenderErrorPolicy`] should be used to respond to a given [`RenderError`].
@@ -50,6 +60,9 @@ impl RenderErrorHandler {
             RenderErrorPolicy::StopRendering => {
                 // do nothing
             }
+            RenderErrorPolicy::QuitApplication => {
+                main_world.write_message(AppExit::error());
+            }
             RenderErrorPolicy::Recover(render_creation) => {
                 assert!(insert_future_resources(&render_creation, main_world));
                 render_world.insert_resource(RenderState::Reinitializing);
@@ -60,9 +73,14 @@ impl RenderErrorHandler {
 
 impl Default for RenderErrorHandler {
     fn default() -> Self {
-        // This is what we've always done historically,
-        // but we could choose a new default once recovery works better.
-        Self(|_, _, _| RenderErrorPolicy::Ignore)
+        // Quit the application for any `RenderError`.
+        // Especially for OOM's and Validation RenderErrors, ignoring the error
+        // and resuming render can cause a loop that can cause hazardous strobing effects.
+        // We can choose a new default once recovery works better.
+        Self(|error, _, _| {
+            bevy_log::error!("Quitting the application due to {:?} RenderError", error.ty);
+            RenderErrorPolicy::QuitApplication
+        })
     }
 }