Skip to content

bevy_render: Do not remove VALIDATION_INDIRECT_CALL if Backends contains DX12 #24129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 6 commits into from
May 6, 2026
+11 −0
Merged

bevy_render: Do not remove VALIDATION_INDIRECT_CALL if Backends contains DX12 #24129

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
73e20c5
fix: add additional conditions for removing VALIDATION_INDIRECT_CALL …
kfc35 May 4, 2026
5515189
remove flag if intending to use vulkan without debug assertions
kfc35 May 5, 2026
226f5c7
remove unnecessary scoping
kfc35 May 5, 2026
ce06060
use is_some_and, wording of DX12
kfc35 May 6, 2026
4ab2304
improve wording of comment
kfc35 May 6, 2026
561c8b1
remove print statement from other work -_-
kfc35 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/bevy_render/src/settings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,13 @@ impl Default for WgpuSettings {
let gles3_minor_version = Gles3MinorVersion::from_env().unwrap_or_default();

let mut instance_flags = InstanceFlags::default();
#[cfg(not(debug_assertions))]
instance_flags.remove(InstanceFlags::VALIDATION_INDIRECT_CALL);
#[cfg(all(not(debug_assertions), not(feature = "raw_vulkan_init")))]
Comment thread
alice-i-cecile marked this conversation as resolved.
Outdated
// wgpu executes additional necessary logic during validation passes for dx-12 backends,
// so the `VALIDATION_INDIRECT_CALL` flag should stay for dx-12.
if !backends.unwrap().contains(Backends::DX12) {
// Removing this flag improves performance.
instance_flags.remove(InstanceFlags::VALIDATION_INDIRECT_CALL);
}
instance_flags = instance_flags.with_env();

Self {
Expand Down
Loading