Reduce bsn! codegen / debug symbols by combining scene implementations#24124
Merged
cart merged 6 commits intobevyengine:mainfrom May 6, 2026
Merged
Reduce bsn! codegen / debug symbols by combining scene implementations#24124cart merged 6 commits intobevyengine:mainfrom
cart merged 6 commits intobevyengine:mainfrom
Conversation
cart
added
C-Performance
alice-i-cecile
added
the
S-Needs-Review
alice-i-cecile
approved these changes
May 6, 2026
laundmo
approved these changes
May 6, 2026
Contributor
laundmo
left a comment
laundmo
left a comment
There was a problem hiding this comment.
Initially i thought SceneFunction would cause issues with asset dependencies, but after asking cart who said it can't contain any code that adds dependencies and testing the case i was thinking of locally, it seems to work as expected.
very nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bsn!currently generates a lot of new types: one for each patch, which then get assembled into a single Scene impl by composing them in a tuple. This gives the compiler more work to do (types to verify, code to generate, etc). It also makes our debug symbols bigger / harder to read.Solution
Combine
bsn!entries, where possible, into a singleSceneFunction<F>implementation ofScene, which does all of the "scene patch" logic internally. This significantly cuts down on codegen, and also makes the functional behavior of absn!block more clear when expanded.