Add more reflection tests for Handle#24115
Open
greeble-dev wants to merge 4 commits intobevyengine:mainfrom
Open
Add more reflection tests for Handle#24115greeble-dev wants to merge 4 commits intobevyengine:mainfrom
Handle#24115greeble-dev wants to merge 4 commits intobevyengine:mainfrom
Conversation
greeble-dev
added
A-Assets
alice-i-cecile
approved these changes
May 4, 2026
Member
|
Broken by the force push noted in #24130; you'll need to clean up the Git history per @cart's message. |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
greeble-dev
force-pushed
the
more-handle-reflect-tests
branch
from
1f77971 to
dd71651
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Build on #24048 to improve test coverage for
Handlereflection, and also repro #24111.Solution
Add various tests. Includes a test for valid cases of
from_reflectandtry_apply- this is relevant sincefrom_reflectnow has a custom implementation.I've snuck in a few cleanups too:
Testing
cargo test -p bevy_asset