Skip to content

Fix: Put back Defaulting of EnvironmentMapUniform#24093

Closed
kfc35 wants to merge 1 commit intobevyengine:mainfrom
kfc35:24084_environment_map_default
Closed

Fix: Put back Defaulting of EnvironmentMapUniform#24093
kfc35 wants to merge 1 commit intobevyengine:mainfrom
kfc35:24084_environment_map_default

Conversation

@kfc35
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 commented May 3, 2026

Objective

Solution

  • Some defaulting logic of EnvironmentMapUniform was removed — this just puts it back. It seems like it is critical to the rendering the desired mirror-y effects of the light_probe_blending and pcss examples, and it resolves the rendering strobing that happens for the affected examples.
  • I do realize that this probably makes the ENVIRONMENTAL_MAP flag useless? Since every camera will then have an EnvironmentalMap. I might do that later (have to sleep!)

Alternative solution: add EnvironmentalMapLight to the examples’ cameras, but I am second guessing that based on the pre-existing function doc comment. It might be a usability thing to not have to include the EnvironmentalMapLight component… albeit I haven’t asked anyone about it.

This is in draft until I make up my mind about modifying the examples and changing user expectations vs putting back in the defaulting behavior. I do like how the feature gating ensures that we use one less uniform buffer...

Testing

  • cargo run --example light_probe_blending --features="free_camera https” looks correct again
  • cargo run --example pcss also looks correct again

@kfc35 kfc35 requested a review from beicause May 3, 2026 05:54
@kfc35 kfc35 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 3, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering May 3, 2026
@kfc35 kfc35 added this to the 0.19 milestone May 3, 2026
@kfc35 kfc35 changed the title Fix: Put back Defaulting of EnvironmentMapLight Fix: Put back Defaulting of EnvironmentMapUniform May 3, 2026
@kfc35 kfc35 force-pushed the 24084_environment_map_default branch from c935f57 to bc1bc6b Compare May 3, 2026 06:11
@kfc35 kfc35 marked this pull request as draft May 3, 2026 06:14
@kfc35 kfc35 added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged S-Needs-Help The author needs help finishing this PR. and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 3, 2026
@beicause
Copy link
Copy Markdown
Member

beicause commented May 3, 2026

See #24095

@kfc35 kfc35 closed this May 3, 2026
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Help The author needs help finishing this PR. S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants