Fix: Put back Defaulting of EnvironmentMapUniform#24093
Closed
kfc35 wants to merge 1 commit intobevyengine:mainfrom
Closed
Fix: Put back Defaulting of EnvironmentMapUniform#24093kfc35 wants to merge 1 commit intobevyengine:mainfrom
EnvironmentMapUniform#24093kfc35 wants to merge 1 commit intobevyengine:mainfrom
Conversation
EnvironmentMapLightEnvironmentMapUniform
c935f57 to
bc1bc6b
Compare
Member
|
See #24095 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
EnvironmentMapUniformwas removed — this just puts it back. It seems like it is critical to the rendering the desired mirror-y effects of thelight_probe_blendingandpcssexamples, and it resolves the rendering strobing that happens for the affected examples.ENVIRONMENTAL_MAPflag useless? Since every camera will then have anEnvironmentalMap. I might do that later (have to sleep!)Alternative solution: add
EnvironmentalMapLightto the examples’ cameras, but I am second guessing that based on the pre-existing function doc comment. It might be a usability thing to not have to include theEnvironmentalMapLightcomponent… albeit I haven’t asked anyone about it.This is in draft until I make up my mind about modifying the examples and changing user expectations vs putting back in the defaulting behavior. I do like how the feature gating ensures that we use one less uniform buffer...
Testing
cargo run --example light_probe_blending --features="free_camera https”looks correct againcargo run --example pcssalso looks correct again