Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions benches/benches/bevy_ecs/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ mod fragmentation;
mod iteration;
mod observers;
mod param;
mod resources;
mod scheduling;
mod world;

Expand All @@ -28,6 +29,7 @@ criterion_main!(
iteration::benches,
fragmentation::benches,
observers::benches,
resources::benches,
scheduling::benches,
world::benches,
param::benches,
Expand Down
69 changes: 69 additions & 0 deletions benches/benches/bevy_ecs/resources.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
use std::{alloc::Layout, hint::black_box, ptr::NonNull};

use benches::bench;
use bevy_ecs::{
change_detection::MaybeLocation,
component::{ComponentCloneBehavior, ComponentDescriptor, StorageType},
prelude::*,
ptr::OwningPtr,
};
use criterion::{criterion_group, Criterion};

criterion_group!(benches, get, get_mut, insert_remove);

fn create_world() -> World {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this does end up being useful, it should probably made part of WorldBuilder.

let mut world = World::new();
for _ in 0..500 {
// SAFETY: Uses zero-sized value, never drops
unsafe {
let resource_id =
world.register_component_with_descriptor(ComponentDescriptor::new_with_layout(
"",
StorageType::SparseSet,
Layout::new::<()>(),
None,
true,
ComponentCloneBehavior::Default,
None,
));
world.insert_resource_by_id(
resource_id,
OwningPtr::new(NonNull::dangling()),
MaybeLocation::caller(),
);
}
}
world
}

#[derive(Resource)]
struct R;

pub fn get(criterion: &mut Criterion) {
let mut world = create_world();
world.insert_resource(R);
criterion.bench_function(bench!("get"), |bencher| {
bencher.iter(|| world.get_resource::<R>());
});
}

pub fn get_mut(criterion: &mut Criterion) {
let mut world = create_world();
world.insert_resource(R);
criterion.bench_function(bench!("get_mut"), |bencher| {
bencher.iter(|| {
black_box(world.get_resource_mut::<R>());
});
});
}

pub fn insert_remove(criterion: &mut Criterion) {
let mut world = create_world();
criterion.bench_function(bench!("insert_remove"), |bencher| {
bencher.iter(|| {
world.insert_resource(R);
black_box(&mut world);
world.remove_resource::<R>()
});
});
}
3 changes: 2 additions & 1 deletion crates/bevy_ecs/macros/src/resource.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use bevy_ecs_macro_logic::component::DeriveComponent;
use bevy_ecs_macro_logic::component::{DeriveComponent, StorageTy};
use proc_macro2::TokenStream;
use quote::quote;
use syn::{DeriveInput, Path};
Expand All @@ -9,6 +9,7 @@ pub fn derive_resource(ast: &mut DeriveInput) -> TokenStream {
Ok(value) => value,
Err(e) => return e.into_compile_error(),
};
derive_component.storage = StorageTy::SparseSet;

let struct_name = &ast.ident;
let (_, type_generics, _) = &ast.generics.split_for_impl();
Expand Down