Skip to content

CI: shared-files test no longer depends on GITHUB_REPOSITORY #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardladenthin merged 1 commit into from
Oct 7, 2026
Merged

CI: shared-files test no longer depends on GITHUB_REPOSITORY #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/buildcheck/tests/test_sharedfiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,16 @@ def test_write_recomputes_the_hashes_and_keeps_the_comments(self):
def test_sibling_differences_are_warnings_not_failures(self):
self.manifest(f"{A} one.sh\n")
others = {"srcmorph": f"{B} one.sh\n", "streambuffer": f"{A} one.sh\n"}
code, err = self.run_main(others=others)
# Pinned: the repository being checked is never fetched, and unpinned it came from
# GITHUB_REPOSITORY -- so in BitcoinAddressFinder's own CI the unreachable sibling this
# test expects was skipped and the test failed there alone.
with mock.patch.object(sharedfiles, "current_repo", return_value="java-llama.cpp"):
code, err = self.run_main(others=others)
self.assertEqual(code, 0)
self.assertIn("::warning::one.sh differs from srcmorph's one.sh", err)
self.assertNotIn("streambuffer's", err)
self.assertIn("could not read BitcoinAddressFinder", err)
self.assertNotIn("java-llama.cpp", err)

def test_unknown_arguments(self):
self.manifest("")
Expand Down
2 changes: 1 addition & 1 deletion .github/shared-files.sha256
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ff2aaec95e53916ea340a0a291bf0f57e0011522aedb486622b1fb1cac136865 .github/buildc
561efd3f26d7728e475c8ce83c10b4761a6703b585b7b2a7ab052df10f73166c .github/buildcheck/tests/helpers.py
4985f25fa177bd79a79335742adfd0da0431e101124b4e7e214906b56ae903de .github/buildcheck/tests/test_workflow.py
cbe504ad081ba31ec16e11c11f879c64179ca7741bf0b1d1318a7fc969ed67dd .github/buildcheck/tests/test_releasegate.py
3ae66ea309fcbceb809de21b5062a3b0eba5e192c69fbc02592accb05d3f400a .github/buildcheck/tests/test_sharedfiles.py
5cece4a0c48e006de32b6ad8c3c675ac349150c2503a0e21b475564eb1a57267 .github/buildcheck/tests/test_sharedfiles.py
7fe208dd33184b4543328f97b339c95e23c408b120e6bfa6095de4182aeb9a19 .github/check-release-gate.py
1604ccdea83998814a3c1f98f746272222039867b0c7d692355e61495c1c648b .github/check-shared-files.py
e5f1679dc7151b2676b2f587860bbaa17e1b89b44a5a4e9703eb3499248c4a06 .github/buildcheck/versions.py
Expand Down
Loading