Repository navigation
CI: shared-files test no longer depends on GITHUB_REPOSITORY - #217
Merged
Merged
Conversation
test_sibling_differences_are_warnings_not_failures expected a "could not read BitcoinAddressFinder" warning from the sibling it leaves unreachable. main() never fetches the repository being checked, and takes its name from GITHUB_REPOSITORY, so in BitcoinAddressFinder's own CI that sibling was skipped and the test failed there alone (red since the test was added; e.g. run 37680715063). The test now pins current_repo, as the other tests in the file do, and asserts the pinned repository is not fetched. Shared file: identical in all four repos, manifests refreshed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
bernardladenthin
had a problem deploying
to
maven-central
October 7, 2026 20:20 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
October 7, 2026 20:20 — with
GitHub Actions
Failure
|
✅ Review approved This PR successfully fixes the flaky test that was failing in BitcoinAddressFinder's CI. The fix correctly isolates the test from the GITHUB_REPOSITORY environment variable by pinning current_repo via mock.patch.object(), matching patterns already established in RepoEntryTest. Key observations:
No issues found — code quality, security, and correctness are all solid. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_sibling_differences_are_warnings_not_failuresin the shared.github/buildcheck/tests/test_sharedfiles.py. Since it was added on 2026-09-30, it has been red in BitcoinAddressFinder's CI only:Shared files + build checks, for example run 37680715063.main()never fetches the repository being checked, and it takes that name fromGITHUB_REPOSITORY. The test expects the sibling it leaves unreachable, BitcoinAddressFinder, to produce acould not read …warning. In BitcoinAddressFinder's own CI that sibling is the current repository and is skipped, so the warning never appeared. Locally (GITHUB_REPOSITORYunset) and in the other three repos the test passed.current_repotojava-llama.cpp, the same way the other tests in the file already mock it, and additionally asserts that the pinned repository is not fetched.Test plan
GITHUB_REPOSITORY=x/BitcoinAddressFinder python3 -m unittest discover -s .github/buildcheck/tests -t .githubfails before the fix and passes after it.check-shared-files.pyreports 0 files changed here alone, with the same hash in all four repos.Related issues / PRs
The same change is made in java-llama.cpp, BitcoinAddressFinder, streambuffer and srcmorph.
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdCI:prefix instead.🤖 Generated with Claude Code
https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
Generated by Claude Code