Skip to content

llama-atmosphere-agent: four open reproductions are green now, so they stop being records - #463

Merged
bernardladenthin merged 1 commit into
mainfrom
agent-reenable-fixed-reproductions
Sep 28, 2026
Merged

bernardladenthin merged 1 commit into
mainfrom
agent-reenable-fixed-reproductions

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

  • Four @Disabled reproductions pass now, so they stop being records. Asked what was still open, I measured it rather than reading the annotations: of the eight disabled cases in ScreenUseCasesTest, four are green. A record of something that is no longer true is worse than no record.
  • None of them was aimed at. They fell out of the console folding its own output, the settled width change wiping and reprinting instead of repairing row by row, and the changes carried against JLine — all merged in llama-atmosphere-agent: make the pinned console survive a window resize #462.
  • Each keeps a note saying what it used to record and why it is green, so the history survives the annotation.
test what it used to record
draggingNarrowerKeepsTheEditLine a "known defect" for most of the investigation: narrowing lost the edit line
draggingWiderWithAThreeRowBlock rule three columns short, state row shifted one column, prompt on two rows
thePromptItselfStaysVisibleAfterEnlarging OPEN for four rounds: block exactly right, prompt's row blank
afterATurnShrinkingAndGrowingKeepsOneRuleNoWiderThanTheWindow OPEN: shrinking and growing left a rule wider than the window

Four remain disabled, and each is still true: three astral-glyph cases (an emoji is a surrogate pair and breaks the pinned region's column arithmetic) and the shrinking-window prompt drift, where the prompt would have to move up and nothing a caller can emit does that without breaking the reader's cursor bookkeeping.

Test plan

  • Affected unit / integration tests pass locally
  • CI is green on this branch
  • Docs / CHANGELOG updated where applicable

ScreenUseCasesTest: 57 tests, 0 failures, 4 skipped — green three times in a row against -Djline.version=4.4.6-atmosphere. Three runs rather than one because this class has a flakiness history, and enabling a test that passes four times in five would be worse than leaving it off.

No production code changes; this is test annotations and comments only.

Related issues / PRs

Follows #462, which is what made these four pass.

Checklist

  • I have read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  • My commits follow Conventional Commits
  • No security-sensitive changes (if there are, I have notified the maintainer privately per SECURITY.md)

Two boxes left open deliberately: CI has not run on this branch yet, and the commit subject follows the surrounding history's pattern (llama-atmosphere-agent: …) rather than test:/fix: — say the word and I will rewrite it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01E2h8gXyyE5UeimkL9vQv9G

…y stop being records

Asked what was still open, and measured it rather than reading the annotations: of the eight
@disabled cases, FOUR pass. They were records of defects the resize work has since fixed, and a
record of something that is no longer true is worse than no record.

  draggingNarrowerKeepsTheEditLine                                (a "known defect" for most of it)
  draggingWiderWithAThreeRowBlock                                 (rule short, state row shifted)
  thePromptItselfStaysVisibleAfterEnlarging                       (OPEN for four rounds)
  afterATurnShrinkingAndGrowingKeepsOneRuleNoWiderThanTheWindow   (OPEN, the other side of it)

None of them was aimed at: they fell out of the console folding its own output, the settled width
change wiping and reprinting instead of repairing row by row, and the seven changes carried against
JLine. Each keeps a note saying what it used to record and why it is green, so the history is not
lost with the annotation. Enabled after three consecutive green runs, because this class has a
flakiness history.

Four remain disabled, and each is still true: three astral-glyph cases (an emoji is a surrogate
pair and breaks the pinned region's column arithmetic) and the shrinking-window prompt drift
documented this week.

ScreenUseCasesTest: 57 tests, 4 skipped, green three times in a row against
-Djline.version=4.4.6-atmosphere.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E2h8gXyyE5UeimkL9vQv9G
@bernardladenthin
bernardladenthin merged commit 674351b into main Sep 28, 2026
10 of 79 checks passed
@bernardladenthin
bernardladenthin deleted the agent-reenable-fixed-reproductions branch September 28, 2026 20:22
@sonarqubecloud

Copy link
Copy Markdown

This branch had an error being deployed

1 failed deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant