Repository navigation
llama-atmosphere-agent: four open reproductions are green now, so they stop being records - #463
Merged
Merged
Conversation
…y stop being records Asked what was still open, and measured it rather than reading the annotations: of the eight @disabled cases, FOUR pass. They were records of defects the resize work has since fixed, and a record of something that is no longer true is worse than no record. draggingNarrowerKeepsTheEditLine (a "known defect" for most of it) draggingWiderWithAThreeRowBlock (rule short, state row shifted) thePromptItselfStaysVisibleAfterEnlarging (OPEN for four rounds) afterATurnShrinkingAndGrowingKeepsOneRuleNoWiderThanTheWindow (OPEN, the other side of it) None of them was aimed at: they fell out of the console folding its own output, the settled width change wiping and reprinting instead of repairing row by row, and the seven changes carried against JLine. Each keeps a note saying what it used to record and why it is green, so the history is not lost with the annotation. Enabled after three consecutive green runs, because this class has a flakiness history. Four remain disabled, and each is still true: three astral-glyph cases (an emoji is a surrogate pair and breaks the pinned region's column arithmetic) and the shrinking-window prompt drift documented this week. ScreenUseCasesTest: 57 tests, 4 skipped, green three times in a row against -Djline.version=4.4.6-atmosphere. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2h8gXyyE5UeimkL9vQv9G
bernardladenthin
had a problem deploying
to
maven-central
September 28, 2026 20:20 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
startgate
September 28, 2026 20:20 — with
GitHub Actions
Error
bernardladenthin
had a problem deploying
to
maven-central
September 28, 2026 20:20 — with
GitHub Actions
Failure
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
@Disabledreproductions pass now, so they stop being records. Asked what was still open, I measured it rather than reading the annotations: of the eight disabled cases inScreenUseCasesTest, four are green. A record of something that is no longer true is worse than no record.draggingNarrowerKeepsTheEditLinedraggingWiderWithAThreeRowBlockthePromptItselfStaysVisibleAfterEnlargingafterATurnShrinkingAndGrowingKeepsOneRuleNoWiderThanTheWindowFour remain disabled, and each is still true: three astral-glyph cases (an emoji is a surrogate pair and breaks the pinned region's column arithmetic) and the shrinking-window prompt drift, where the prompt would have to move up and nothing a caller can emit does that without breaking the reader's cursor bookkeeping.
Test plan
ScreenUseCasesTest: 57 tests, 0 failures, 4 skipped — green three times in a row against-Djline.version=4.4.6-atmosphere. Three runs rather than one because this class has a flakiness history, and enabling a test that passes four times in five would be worse than leaving it off.No production code changes; this is test annotations and comments only.
Related issues / PRs
Follows #462, which is what made these four pass.
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)Two boxes left open deliberately: CI has not run on this branch yet, and the commit subject follows the surrounding history's pattern (
llama-atmosphere-agent: …) rather thantest:/fix:— say the word and I will rewrite it.🤖 Generated with Claude Code
https://claude.ai/code/session_01E2h8gXyyE5UeimkL9vQv9G