Skip to content

Commit 674351b

Browse files
Merge pull request #463 from bernardladenthin/agent-reenable-fixed-reproductions
llama-atmosphere-agent: four open reproductions are green now, so they stop being records
2 parents 56891c7 + bdaadc9 commit 674351b

1 file changed

Lines changed: 13 additions & 14 deletions

File tree

‎llama-atmosphere-agent/src/test/java/net/ladenthin/llama/atmosphere/ScreenUseCasesTest.java‎

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,10 @@ void draggingNarrowerLeavesOneCleanBlock() throws Exception {
277277
}
278278

279279
@Test
280-
@Disabled("Known defect, and this test is the record of it: dragging the window NARROWER loses the"
281-
+ " edit line entirely -- reported as \"beim kleiner ziehen ist der Text nicht mehr"
282-
+ " sichtbar\" and reproduced here as zero occurrences of \"> Hallo\" on an otherwise"
283-
+ " correct screen. Not caused by anything in this class: the block and the state row end up"
284-
+ " exactly where they belong. Delete the annotation to see it.")
280+
// Was @Disabled as "a known defect" for most of this investigation: dragging the window narrower lost the
281+
// edit line entirely. It passes now, and nothing was aimed at it -- it fell out of the console folding its own
282+
// output, the settled width change wiping and reprinting, and the seven changes carried against JLine. Enabled
283+
// after being re-measured rather than left as a record of something that is no longer true.
285284
void draggingNarrowerKeepsTheEditLine() throws Exception {
286285
ScreenTerminalHarness terminal = terminal(WIDE);
287286
try (JLineTerminal console = start(terminal, List.of(STATE))) {
@@ -314,11 +313,9 @@ void draggingNarrowerWithAThreeRowBlockLeavesOneCleanBlock() throws Exception {
314313
}
315314

316315
@Test
317-
@Disabled("Known defect, and this test is the record of it: with a THREE-row block a wide drag ends"
318-
+ " with the rule three columns short of the window (96 of 99, with a gap near its end), the"
319-
+ " state row shifted one column right, and the prompt on two rows. A two-row block comes"
320-
+ " out clean, which is what makes the row count the discriminator. Delete the annotation to"
321-
+ " see it.")
316+
// Was @Disabled: with a THREE-row block a wide drag used to end with the rule three columns short, the state
317+
// row shifted one column and the prompt on two rows, while a two-row block came out clean. Green now; the
318+
// column shift was the off-by-one in the row addressing (columns vs columns + 1), the rest followed the wipe.
322319
void draggingWiderWithAThreeRowBlock() throws Exception {
323320
// The shape the agent actually pins: a rule plus an activity row plus a state row.
324321
List<String> block = new ArrayList<>(Arrays.asList("... waiting for input ...", STATE));
@@ -956,8 +953,9 @@ public Size getSize() {
956953
}
957954

958955
@Test
959-
@Disabled(
960-
"Reproduced and OPEN, with four candidates eliminated by bisection and one named. After a series of size changes the block sits exactly right while the prompt row is blank. Ruled out by measurement, each a separate run: this console re-establishing the region (Status.resize), this console rebuilding the rows at all, JLine handleSignal calling Status.resize, and JLine handleSignal calling redisplay -- red with every one of them switched off. Also ruled out: the screen model itself, which keeps text across resizes (ScreenTerminalHarnessTest). The candidate left is Status.update clearing excess rows from display.rows - oldLinesSize, which reaches ABOVE the region when that count is stale. Delete the annotation to see it.")
956+
// Was @Disabled and OPEN for four rounds: after a series of size changes the block sat exactly right while the
957+
// prompt's row was blank. Four candidates had been eliminated by bisection. Green now -- the prompt is printed
958+
// back to its row after a height change, and a width change wipes and redraws instead of diffing.
961959
void thePromptItselfStaysVisibleAfterEnlarging() throws Exception {
962960
// A gap in every assertion above, and it is why they were all green while the console was not.
963961
// They ask that no row carries the prompt AND the rule -- but when the rule is drawn ON the prompt's
@@ -1007,8 +1005,9 @@ void thePromptItselfStaysVisibleAfterEnlarging() throws Exception {
10071005
}
10081006

10091007
@Test
1010-
@Disabled(
1011-
"Reproduced and OPEN, the same defect from the other side: with a turn already on screen, shrinking and growing erases the answer while the rule assertions hold. Same bisection as the test above -- neither this console nor either half of JLine handleSignal is the writer that erases it, and the screen model keeps text across resizes. Delete the annotation to see it.")
1008+
// Was @Disabled and OPEN: with a turn already on screen, shrinking and growing left a rule wider than the
1009+
// window. Green now, and the reason is the one the reflowing harness finally showed -- the console re-wraps
1010+
// what is on screen, and the settled width change wipes rather than trying to repair it row by row.
10121011
void afterATurnShrinkingAndGrowingKeepsOneRuleNoWiderThanTheWindow() throws Exception {
10131012
// Both halves of the latest report in one case, because both are the same measurement from
10141013
// different sides: shrinking moves the input area and the output up, and growing produces a rule

0 commit comments

Comments
 (0)