Skip to content

Repository navigation

CI: add Ubuntu Polish locale lane and locale bootstrap to CLI PR tests #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdhanna merged 8 commits into from
May 21, 2026
Merged

CI: add Ubuntu Polish locale lane and locale bootstrap to CLI PR tests #4607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7e13b90
Initial plan
Copilot May 19, 2026
6519d88
ci: add Polish culture lane to CLI PR test matrix
Copilot May 19, 2026
f496f82
ci: run Polish CLI locale lane only on ubuntu
Copilot May 19, 2026
20be726
ci: generate ubuntu locale before cli locale lane tests
Copilot May 19, 2026
0d15ecc
ci: guard locale setup when matrix lang is undefined
Copilot May 19, 2026
ae8527d
ci: simplify locale step condition for ubuntu matrix lanes
Copilot May 19, 2026
977171a
ci: run locale setup before cli test job restore/build steps
Copilot May 19, 2026
de1eda8
fix: use invariant culture when parsing storage target framework version
Copilot May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions .github/workflows/buildPR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,20 +82,32 @@ jobs:
timeout-minutes: 30
runs-on: ${{ matrix.runners }}
concurrency:
group: cli-pr-${{ github.sha }}-${{ matrix.dotnet-version }}-${{matrix.runners}}
group: cli-pr-${{ github.sha }}-${{ matrix.dotnet-version }}-${{ matrix.runners }}-${{ matrix.test-culture }}
cancel-in-progress: true
Comment on lines 84 to 86
strategy:
max-parallel: 2
matrix:
dotnet-version: ['10.0.x' ]
runners: [ windows-latest, ubuntu-latest ]
include:
- runners: windows-latest
test-culture: en-US
Comment on lines 89 to +93
dotnet-cli-ui-language: en
- runners: ubuntu-latest
test-culture: en-US
dotnet-cli-ui-language: en
lang: en_US.UTF-8
- runners: ubuntu-latest
test-culture: pl-PL
dotnet-cli-ui-language: pl
lang: pl_PL.UTF-8
env:
BEAM_DOCKER_WINDOWS_CONTAINERS: ${{ matrix.runners == 'windows-latest' && '1' || '0' }}
DOTNET_CLI_UI_LANGUAGE: ${{ matrix.dotnet-cli-ui-language }}
Comment on lines 103 to +105
steps:
- name: Check Docker
run: docker version
- name: Check concurrency
run: echo 'cli-pr-${{ github.sha }}-${{ matrix.dotnet-version }}-${{matrix.runners}}'
run: echo 'cli-pr-${{ github.sha }}-${{ matrix.dotnet-version }}-${{ matrix.runners }}-${{ matrix.test-culture }}'
- uses: actions/checkout@v4
- name: Setup .NET Core SDK ${{ matrix.dotnet-version }}
uses: actions/setup-dotnet@v4
Expand All @@ -108,6 +120,12 @@ jobs:
key: ${{ runner.os }}-nuget-${{ hashFiles('**/packages.lock.json') }}
restore-keys: |
${{ runner.os }}-nuget
- name: Configure locale
if: matrix.runners == 'ubuntu-latest' && matrix.lang
run: |
sudo locale-gen ${{ matrix.lang }}
echo "LANG=${{ matrix.lang }}" >> "$GITHUB_ENV"
echo "LC_ALL=${{ matrix.lang }}" >> "$GITHUB_ENV"
- name: Install Go
uses: actions/setup-go@v5
with:
Expand All @@ -131,7 +149,7 @@ jobs:
- name: Build
run: dotnet build --configuration Release --no-restore cli/tests -p:BeamOverrideVersionWithLocalDev=true
- name: Test
run: dotnet test --configuration Release --no-build cli/tests -p:BeamOverrideVersionWithLocalDev=true
run: dotnet test --configuration Release --no-build cli/tests -p:BeamOverrideVersionWithLocalDev=true -- NUnit.DefaultCulture=${{ matrix.test-culture }}
testSourceGen:
timeout-minutes: 10
runs-on: ubuntu-latest
Expand Down Expand Up @@ -443,4 +461,3 @@ jobs:
allowDirtyBuild: true
buildsPath: dist
buildMethod: BuildSampleProject.Development

2 changes: 1 addition & 1 deletion cli/cli/Commands/Project/NewStorageCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public override void Configure()
() =>
{
var currentVersion = AppContext.TargetFrameworkName.Split('=')[1].Substring(1);
var currentVersionDouble = double.Parse(currentVersion);
var currentVersionDouble = double.Parse(currentVersion, System.Globalization.CultureInfo.InvariantCulture);
if (currentVersionDouble < 8.0)
{
currentVersion = "8.0";
Expand Down
Loading