CI: add Ubuntu Polish locale lane and locale bootstrap to CLI PR tests by Copilot · Pull Request #4607 · beamable/BeamableProduct

Copilot · 2026-05-19T13:38:21Z

Inspect failing stack trace and locate culture-sensitive parse in NewStorageCommand
Confirm similar command (NewMicroserviceCommand) uses invariant parsing
Update storage target framework parsing to be culture-invariant
Run targeted CLI validation (dotnet build cli/cli/cli.csproj with local version override)
Run final validation (code review + CodeQL)
Save session context for follow-up

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/52e7b1da-0b7c-4ba3-95ac-792d71d1a8c2 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

cdhanna

@copilot , is it possible to only urn the PL stuff on the ubuntu-latest side?

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/54bf7625-5604-4047-8940-10e56532a4eb Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

Copilot · 2026-05-19T13:59:35Z

@copilot , is it possible to only urn the PL stuff on the ubuntu-latest side?

Done — I removed the Windows pl-PL lane and now run Polish localization only on ubuntu-latest in testCli. Commit: f496f82.

cdhanna · 2026-05-19T14:33:25Z

@copilot , see the test output for the cli github action

Run dotnet test --configuration Release --no-build cli/tests -p:BeamOverrideVersionWithLocalDev=true -- NUnit.DefaultCulture=pl-PL
/usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (pl_PL.UTF-8)
Przebieg testu dla: /home/runner/work/BeamableProduct/BeamableProduct/cli/tests/bin/Release/net10.0/tests.dll

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/353c6acc-6de9-48d5-8edc-0a1094eea639 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

Copilot · 2026-05-19T14:39:00Z

@copilot , see the test output for the cli github action

Run dotnet test --configuration Release --no-build cli/tests -p:BeamOverrideVersionWithLocalDev=true -- NUnit.DefaultCulture=pl-PL
...

Fixed in 977171a: the Ubuntu lane now generates the requested locale (sudo locale-gen ${{ matrix.lang }}) and exports LANG/LC_ALL before restore/build/test steps, so pl_PL.UTF-8 is available when dotnet test runs.

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/c53a7823-61c0-4eb2-8939-4c011ae6ffd7 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

github-actions · 2026-05-20T13:00:53Z

Lightbeam link

Copilot

Pull request overview

This PR aims to make CLI PR testing resilient to non-English locales (specifically Polish) by running an additional Ubuntu lane with pl-PL settings and by fixing a culture-sensitive parse in NewStorageCommand that can fail under locales using , as the decimal separator.

Changes:

Make NewStorageCommand target framework parsing culture-invariant.
Expand the CLI PR test workflow matrix to add an Ubuntu pl-PL lane and bootstrap locale settings.
Pass an explicit NUnit default culture into dotnet test for the CLI test job.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
`cli/cli/Commands/Project/NewStorageCommand.cs`	Uses invariant culture for framework version parsing to avoid locale-dependent failures.
`.github/workflows/buildPR.yml`	Adds Ubuntu Polish locale lane and locale bootstrapping; updates concurrency grouping and test invocation culture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

      matrix:
        dotnet-version: ['10.0.x' ]
-        runners: [ windows-latest, ubuntu-latest ]
+        include:
+          - runners: windows-latest
+            test-culture: en-US


    concurrency:
-      group: cli-pr-${{ github.sha }}-${{ matrix.dotnet-version }}-${{matrix.runners}}
+      group: cli-pr-${{ github.sha }}-${{ matrix.dotnet-version }}-${{ matrix.runners }}-${{ matrix.test-culture }}
      cancel-in-progress: true


    env:
      BEAM_DOCKER_WINDOWS_CONTAINERS: ${{ matrix.runners == 'windows-latest' && '1' || '0' }}
+      DOTNET_CLI_UI_LANGUAGE: ${{ matrix.dotnet-cli-ui-language }}


…emantics The locale work in #4607 replaced the two-value `runners` matrix dimension with a hand-enumerated `include:` block. GitHub merges an include entry into an existing combination when its keys are absent from the base matrix instead of appending a new one, so all three entries collapsed onto the single `dotnet-version: 10.0.x` combination and the last one won. Since 2026-05-21 testCli has run exactly one lane: ubuntu, Polish. Windows and English CLI coverage were silently dropped, and every lane would have been named `testCli (10.0.x)` regardless, so nothing looked missing. Promote `runners` and `test-culture` back to matrix dimensions, drop the Windows/Polish pair with `exclude`, and use `include` for what it is for -- attaching keys to combinations that already exist. This yields the three intended lanes and makes them self-identifying in the checks list. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Initial plan

7e13b90

Copilot AI assigned Copilot and cdhanna May 19, 2026

ci: add Polish culture lane to CLI PR test matrix

6519d88

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/52e7b1da-0b7c-4ba3-95ac-792d71d1a8c2 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

Copilot started work on behalf of cdhanna May 19, 2026 13:42 View session

Copilot AI linked an issue May 19, 2026 that may be closed by this pull request

Add CLI test env that uses Polish localization #4548

Closed

Copilot AI changed the title ~~[WIP] Add CLI test environment for Polish localization~~ CI: add Polish locale lanes to CLI PR tests May 19, 2026

Copilot AI requested a review from cdhanna May 19, 2026 13:44

Copilot finished work on behalf of cdhanna May 19, 2026 13:53

cdhanna requested changes May 19, 2026

View reviewed changes

ci: run Polish CLI locale lane only on ubuntu

f496f82

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/54bf7625-5604-4047-8940-10e56532a4eb Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

Copilot started work on behalf of cdhanna May 19, 2026 14:00 View session

Copilot AI changed the title ~~CI: add Polish locale lanes to CLI PR tests~~ CI: add Ubuntu Polish locale lane to CLI PR tests May 19, 2026

Copilot AI requested a review from cdhanna May 19, 2026 14:01

Copilot finished work on behalf of cdhanna May 19, 2026 14:20

Copilot started work on behalf of cdhanna May 19, 2026 14:33 View session

Copilot AI and others added 4 commits May 19, 2026 14:35

ci: generate ubuntu locale before cli locale lane tests

20be726

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/353c6acc-6de9-48d5-8edc-0a1094eea639 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

ci: guard locale setup when matrix lang is undefined

0d15ecc

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/353c6acc-6de9-48d5-8edc-0a1094eea639 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

ci: simplify locale step condition for ubuntu matrix lanes

ae8527d

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/353c6acc-6de9-48d5-8edc-0a1094eea639 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

ci: run locale setup before cli test job restore/build steps

977171a

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/353c6acc-6de9-48d5-8edc-0a1094eea639 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

Copilot AI changed the title ~~CI: add Ubuntu Polish locale lane to CLI PR tests~~ CI: add Ubuntu Polish locale lane and locale bootstrap to CLI PR tests May 19, 2026

Copilot finished work on behalf of cdhanna May 19, 2026 14:58

Copilot started work on behalf of cdhanna May 19, 2026 21:13 View session

fix: use invariant culture when parsing storage target framework version

de1eda8

Agent-Logs-Url: https://github.com/beamable/BeamableProduct/sessions/c53a7823-61c0-4eb2-8939-4c011ae6ffd7 Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>

Copilot finished work on behalf of cdhanna May 19, 2026 21:17

cdhanna marked this pull request as ready for review May 21, 2026 14:20

Copilot AI review requested due to automatic review settings May 21, 2026 14:20

Copilot started reviewing on behalf of cdhanna May 21, 2026 14:20 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

cdhanna merged commit 6deb1b6 into main May 21, 2026
47 of 48 checks passed

cdhanna deleted the copilot/add-cli-test-env-polish-localization branch May 21, 2026 14:28

Navigation Menu

Repository navigation

CI: add Ubuntu Polish locale lane and locale bootstrap to CLI PR tests - #4607

CI: add Ubuntu Polish locale lane and locale bootstrap to CLI PR tests#4607
cdhanna merged 8 commits into
mainfrom
copilot/add-cli-test-env-polish-localization

Copilot AI commented May 19, 2026 •

edited

Loading

Uh oh!

cdhanna left a comment

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

cdhanna commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdhanna left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

cdhanna commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 19, 2026 •

edited

Loading