fix: windows functionality and tests#334
Merged
cgrindel merged 2 commits intobazel-contrib:mainfrom Jul 3, 2024
Merged
Conversation
cgrindel
reviewed
Jun 29, 2024
Contributor
Author
|
I've updated this PR, could someone please approve the CI workflow? |
Member
|
I approved the CI. |
cgrindel
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are four issues when running on windows:
This PR fixes 3 and 4.
There are related PRs in bazel-skylib and bazel-starlib. There is no dependency -- the PRs can close in any order.
Test results:
Before:
--enable_runfiles: 0 pass
--noenable_runfiles: 0 pass
After this PR:
--enable_runfiles: 52 pass, 19 failures
--noenable_runfiles: 51 pass, 20 failures (17 are doc diff-tests due to bazel-starlib)
After this PR, together with wip PRs for 1 and 2:
--enable_runfiles: 71 pass, 0 failures
--noenable_runfiles: 51 pass, 20 failures (all due to bazel-starlib)