-
Notifications
You must be signed in to change notification settings - Fork 539
Add --package-only to aws_build_dcp_from_cl.py to package an existing DCP #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: f2
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -256,6 +256,14 @@ def main(): | |
| default=True, | ||
| ) | ||
|
|
||
| parser.add_option( | ||
| "--package-only", | ||
| dest="package_only", | ||
| action="store_true", | ||
| default=False, | ||
| help="Skip Vivado and package an existing post-route DCP. Requires --tag matching the checkpoint timestamp.", | ||
| ) | ||
|
|
||
| (options, args) = parser.parse_args() | ||
|
|
||
| print("==================================================") | ||
|
|
@@ -323,18 +331,21 @@ def main(): | |
|
|
||
| Custom `clock_recipe` arguments were detected, please add `--aws_clk_gen` to continue.""") | ||
|
|
||
| # Run the Vivado job | ||
| cmd = ( | ||
| f"vivado -mode batch -source build_all.tcl -log {build_tag}.vivado.log " | ||
| + f"-tclargs {options.place_direct} {options.phy_opt_direct} {options.route_direct} " | ||
| + f"{options.clock_recipe_a} {options.clock_recipe_b} {options.clock_recipe_c} {options.clock_recipe_hbm} " | ||
| ) | ||
|
|
||
| start_time = datetime.datetime.now() | ||
| print(f"\nAWS FPGA: {start_time.strftime(TIMESTAMP_LOG_FORMAT)} - Build starts\n") | ||
|
|
||
| sys.stdout.flush() | ||
| os.system(cmd) | ||
|
|
||
| if options.package_only: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: this validation (missing Let's move this whole block above the start banner print, before the start banner print. |
||
| if not options.build_tag: | ||
| print_error("--package-only requires --tag matching an existing post-route DCP (for example -t YYYY_MM_DD-HHMMSS)") | ||
| print(f"AWS FPGA: --package-only set, skipping Vivado and packaging tag {build_tag}\n") | ||
|
Comment on lines
+358
to
+364
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would be a nice-to-have. |
||
| else: | ||
| cmd = ( | ||
| f"vivado -mode batch -source build_all.tcl -log {build_tag}.vivado.log " | ||
| + f"-tclargs {options.place_direct} {options.phy_opt_direct} {options.route_direct} " | ||
| + f"{options.clock_recipe_a} {options.clock_recipe_b} {options.clock_recipe_c} {options.clock_recipe_hbm} " | ||
| ) | ||
|
Comment on lines
+366
to
+370
|
||
| os.system(cmd) | ||
|
|
||
| if options.flow == "BuildAll": | ||
| generate_dcp_tarball( | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.