Skip to content

chore(deps): update xxhash requirement from <3.9,>=3.4 to >=3.4,<4.1 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

chore(deps): update xxhash requirement from <3.9,>=3.4 to >=3.4,<4.1 #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ dependencies = [
"boto3 >= 1.42.29; python_version >= '3.9'",
"boto3 >= 1.36.8; python_version < '3.9'",
"typing_extensions >= 4.8",
"xxhash >= 3.4,< 3.9",
"xxhash >= 3.4,< 4.1",

@github-actions github-actions Bot Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This widens the range across a major-version boundary (< 3.9 → < 4.1), which pre-approves xxhash 4.x — a release that does not exist yet and whose API/behavior is by definition unconstrained by semver compatibility promises.

Two specific risks:

  1. Digest stability. xxh3_128 hex digests are persisted in asset manifests and used for content-addressed storage keys (hash_file/hash_data in src/deadline/job_attachments/asset_manifests/hash_algorithms.py). If a future 4.x changes digest output, seeds/defaults, or hexdigest() byte order, previously uploaded CAS objects stop resolving and clients on different xxhash majors compute different keys for identical content — a silent cache-miss / re-upload problem rather than a loud failure.
  2. API availability. from xxhash import xxh3_128 is an unguarded import; if 4.x renames or removes that symbol, this raises ImportError at hash time rather than at install time.

Neither can be validated today because there is nothing in 4.x to test against, so CI passing here only proves 3.x still works.

Suggest keeping the ceiling below the next major (e.g. xxhash >= 3.4,< 4.0) and raising it deliberately once 4.x ships and digest stability has been verified. If the intent was specifically to unblock a newly released 3.9/3.10, < 4.0 covers that too.

"pywin32 >= 307; sys_platform == 'win32'",
"psutil >= 7.0.0"
]
Expand Down
Loading