chore(deps): update xxhash requirement from <3.9,>=3.4 to >=3.4,<4.1 - #69
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [xxhash](https://github.com/ifduyue/python-xxhash) to permit the latest version. - [Release notes](https://github.com/ifduyue/python-xxhash/releases) - [Changelog](https://github.com/ifduyue/python-xxhash/blob/master/CHANGELOG.rst) - [Commits](ifduyue/python-xxhash@v3.4.0...v4.0.0) --- updated-dependencies: - dependency-name: xxhash dependency-version: 4.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
epmog
force-pushed
the
dependabot/pip/xxhash-gte-3.4-and-lt-4.1
branch
from
September 1, 2026 16:31
fc77ca1 to
2f1c5bb
Compare
| "boto3 >= 1.36.8; python_version < '3.9'", | ||
| "typing_extensions >= 4.8", | ||
| "xxhash >= 3.4,< 3.9", | ||
| "xxhash >= 3.4,< 4.1", |
There was a problem hiding this comment.
This widens the range across a major-version boundary (< 3.9 → < 4.1), which pre-approves xxhash 4.x — a release that does not exist yet and whose API/behavior is by definition unconstrained by semver compatibility promises.
Two specific risks:
- Digest stability.
xxh3_128hex digests are persisted in asset manifests and used for content-addressed storage keys (hash_file/hash_datainsrc/deadline/job_attachments/asset_manifests/hash_algorithms.py). If a future 4.x changes digest output, seeds/defaults, orhexdigest()byte order, previously uploaded CAS objects stop resolving and clients on different xxhash majors compute different keys for identical content — a silent cache-miss / re-upload problem rather than a loud failure. - API availability.
from xxhash import xxh3_128is an unguarded import; if 4.x renames or removes that symbol, this raisesImportErrorat hash time rather than at install time.
Neither can be validated today because there is nothing in 4.x to test against, so CI passing here only proves 3.x still works.
Suggest keeping the ceiling below the next major (e.g. xxhash >= 3.4,< 4.0) and raising it deliberately once 4.x ships and digest stability has been verified. If the intent was specifically to unblock a newly released 3.9/3.10, < 4.0 covers that too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Updates the requirements on xxhash to permit the latest version.
Release notes
Sourced from xxhash's releases.
Changelog
Sourced from xxhash's changelog.
... (truncated)
Commits
5c5e42fRelease v4.0.088fe191Bump version to 4.0.0.dev89628b66Unify lock allocation and GIL release thresholdsb274f52Bump version to 4.0.0.dev739e4481Simplify hash type name getters8b83ba2Bump version to 4.0.0.dev6af052b0Unify invalid-keyword error message across constructors51505c7Bump version to 4.0.0.dev59b2bc9dfix: correct positional-seed tests in test_fastcall94c3289Update changelog for 4.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)