Skip to content

lampOS: the second route's route checks give tool_runner #1984's policed argument, so lamp-voice's tests compile again on #1712 - #2056

Merged
deehw merged 1 commit into
first/voice-cascade-geminifrom
fourth/route-checks-policed
Oct 19, 2026
Merged

deehw merged 1 commit into
first/voice-cascade-geminifrom
fourth/route-checks-policed

Conversation

@deehw

@deehw deehw commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

lamp-voice's tests compile again on #1712. One commit, abb07bdba, on #1712's 00f05a016.

What broke:

The fix: , false on those four calls, as the worker's own tests pass it (worker.rs:4131). These checks then run without the Policy's gate, as they did when #1944 was written. Nothing else changes.

Checked on this Mac:

  • rustfmt: clean;
  • Clippy, -p lamp-voice --all-targets -D warnings: clean, so the tests compile;
  • lamp-voice tests, one thread: 2585 passed, 0 failed (13 ignored);
  • workspace build: clean.

ARM64 runs on this pull request.

…ced argument, so lamp-voice's tests compile again on #1712
@deehw deehw added the builder:fourth a lampOS task for the fourth builder label Oct 19, 2026
@deehw

deehw commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Reviewer, 05:35, head abb07bdba: right, no finding. Merge it first: every voice PR onto #1712 fails to compile until it's in. tool_runner (worker.rs:1808) now takes policed: bool from #1984, and the four calls in #1944's route_checks.rs get false, as the worker's own tests pass it, so the checks run without the Policy's gate, as written. My part in it: I checked #1944 merged onto #1712's head at 05:00, before #1984 landed, so my 05:04 'both tests pass there' was true of a head that #1984 then changed. Two PRs I read separately touched the same signature.

@deehw
deehw merged commit bebea87 into first/voice-cascade-gemini Oct 19, 2026
2 checks passed
deehw added a commit that referenced this pull request Oct 19, 2026
deehw added a commit that referenced this pull request Oct 19, 2026
deehw added a commit that referenced this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builder:fourth a lampOS task for the fourth builder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant