Repository navigation
lampOS: probe-tools asks #2054's day lines, one cut short among them, as the second route's rule judges them - #2068
Merged
Conversation
Collaborator
|
Reviewer, 06:09, head
[P3] A fourth line would measure my P3 on #2054. "I forget his name, do you remember?", said to someone else, should keep the note and call nothing (or |
daniel-auto
force-pushed
the
eighth/heeding-probe
branch
from
October 19, 2026 23:10
45b41d8 to
958b89b
Compare
Collaborator
Author
daniel-auto
force-pushed
the
eighth/heeding-probe
branch
from
October 19, 2026 23:28
958b89b to
4db36c9
Compare
… as the second route's rule judges them, and puts each first call to its hold
daniel-auto
force-pushed
the
eighth/heeding-probe
branch
from
October 19, 2026 23:57
4db36c9 to
af25a98
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2054 (Third's
fb23da10d, with the P2 fix): merge after it. The first builder's 05:43 on #1722, item 1: played cases for #2054, on the second route, each failing on #1712's head before #2054 and passing with it.probe-toolsgains the heeding's four lines (HEEDING_LINES). Each runs as the engine runs it:worker::Heeding, with--spoken-to), going on from a conversation in which the lamp asked nothing. So each is let out only as the conversation going on, as on lamp-4ace.conversation_note_for, else the call note, beside the line.holds_call.The four lines:
remind: "Remind me in two minutes to stretch." Right isset_reminder, not held.remind-split: "Remind me, in two minutes, to drink some water.", cut short after "Remind me," and gone on with as the next request (continues_from). Right is the same; it's judged on the whole chain's words. This was my P2 on lampOS: the second route lets a line naming the schedule set it, as Live does, and doesn't tell a line asking to remember or forget that it may be people's talk (#1712) #2054, fixed infb23da10d.to-someone: "Yes, give me five minutes.", said to someone else. Right is no schedule call run: none called, or held.remember: "Remember that my favourite colour is green." Right isremember, nevernot_for_me.Functions: the model gets every function a spoken turn declares, plus the schedule's. The schedule's are read from the actions part's catalog, as a voice with
--schedule-toolsreads them. Where the catalog has no schedule, the lines aren't asked, and the probe says so; the other sections still run. It printsright=N/Mand the functions called first per line: counts and names only.Before and after #2054 (
the_heeding_lines_are_judged_by_the_routes_own_rule, and the fake-chat test):worker.rs: both pass.e35f1ddc9worker.rsput back: both fail.remind'sset_reminderis held.c64d3c86cworker.rs(before the P2 fix): both fail onremind-splitalone.remindheld,remembertoldCONVERSATION_ALONE) fails on the head every time.not_for_meforrememberunder that note is DeepSeek's choice. The probe on lamp-4ace counts it.to-someonestays right on both, held. It's the guard that lampOS: the second route lets a line naming the schedule set it, as Live does, and doesn't tell a line asking to remember or forget that it may be people's talk (#1712) #2054 doesn't let talk set the schedule.Docs:
second-voice.md, underprobe-tools.Gate (Linux):
cargo test -p lamp-voice --lib -- second_provider: 310 passed, 0 failed (probe::tools12);clippy -p lamp-voice --all-targets -D warnings: ok;fmt --check: ok.These were run with #2056's
route_checks.rsfix applied locally (not in this PR), sincee35f1ddc9doesn't build its tests. #2056 is in #1712 now.Not run: the probe against DeepSeek. That's on the lamp, with
LoadCredential, as in the docs.