Skip to content

lampOS: Jarvis's voice features checked on the second route: reports_stop and dance (held reports_stop fixed in #1925, reports_state on lamp-voice) - #1944

Merged
deehw merged 1 commit into
first/voice-cascade-geminifrom
jarvis/route2-checks
Oct 19, 2026
Merged

deehw merged 1 commit into
first/voice-cascade-geminifrom
jarvis/route2-checks

Conversation

@loclt1011

Copy link
Copy Markdown
Collaborator

Onto #1712's head (first/voice-cascade-gemini at d9e90ad), where the second route is built. These are tests only, with no change in behaviour.

second_provider/worker/route_checks.rs checks each feature with the worker's own pieces: the flags parsed by parse_flags, the chat's declaration (tools::declared with with_search, and few_tools) and tool_runner.

reports_stop_is_declared_with_its_switch_and_run_on_the_reports:

  • LAMP_REPORTS=on declares reports_stop, and it is not declared without it.
  • With LAMP_SECOND_FEW_TOOLS=on it waits behind more_functions, which names it.
  • Its call runs on the reports, not "not running". An unheard call is refused.

dance_is_declared_from_the_skills_tools_file_and_reaches_their_socket:

  • dance is declared from the skills' tools.json.
  • Its call reaches the skills' socket as {"op":"call","name":"dance","args":{"style":"jazz"}}.
  • With LAMP_USE_SKILL=on, use_skill names dance and its call reaches the socket the same way.

Both pass on #1712's head as it is.

The held reports_stop was broken on this route and is fixed in #1925. reports_state (#1906) is not on #1712's head yet; its second-route check is on a lamp-voice branch.

Gate.

  • cargo fmt --all --check and clippy (-D warnings -A deprecated -A clippy::chunks_exact_to_as_chunks -A clippy::byte_char_slices) are clean.
  • cargo test -p lamp-voice: 2189 passed, 13 failed. All 13 are timed tests outside this change: coordinator::motor (owned child timed out, on a Mac under load 8), reminders::transport claim retention, and ring_worker flood. ring_worker and reminders passed when rerun alone. coordinator::motor still fails alone on this Mac, and on lampOS: the second route does a held line's reports_stop and keeps its answer held, as the Live route does, with LAMP_REPORTS=on #1925's branch, where it had passed earlier. ARM64 decides.
  • ARM64: gh workflow run "lampOS on ARM64" --ref jarvis/route2-checks

Still needs lamp time: one real-route trial per feature, through the first builder.

…from the worker's flags and run by its own runner
@deehw

deehw commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Reviewer, 05:05, head 1cd89dcd3: no finding, and sorry it waited (my watcher didn't follow PRs onto #1712; it does now). Tests only, no behaviour change; it's the first builder's to merge into #1712.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants