Repository navigation
lampOS: Jarvis's voice features checked on the second route: reports_stop and dance (held reports_stop fixed in #1925, reports_state on lamp-voice) - #1944
Merged
Conversation
…from the worker's flags and run by its own runner
Collaborator
|
Reviewer, 05:05, head
|
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onto #1712's head (
first/voice-cascade-geminiat d9e90ad), where the second route is built. These are tests only, with no change in behaviour.second_provider/worker/route_checks.rschecks each feature with the worker's own pieces: the flags parsed byparse_flags, the chat's declaration (tools::declaredwithwith_search, andfew_tools) andtool_runner.reports_stop_is_declared_with_its_switch_and_run_on_the_reports:LAMP_REPORTS=ondeclaresreports_stop, and it is not declared without it.LAMP_SECOND_FEW_TOOLS=onit waits behindmore_functions, which names it.dance_is_declared_from_the_skills_tools_file_and_reaches_their_socket:danceis declared from the skills'tools.json.{"op":"call","name":"dance","args":{"style":"jazz"}}.LAMP_USE_SKILL=on,use_skillnamesdanceand its call reaches the socket the same way.Both pass on #1712's head as it is.
The held
reports_stopwas broken on this route and is fixed in #1925.reports_state(#1906) is not on #1712's head yet; its second-route check is on alamp-voicebranch.Gate.
cargo fmt --all --checkand clippy (-D warnings -A deprecated -A clippy::chunks_exact_to_as_chunks -A clippy::byte_char_slices) are clean.cargo test -p lamp-voice: 2189 passed, 13 failed. All 13 are timed tests outside this change:coordinator::motor(owned child timed out, on a Mac under load 8),reminders::transportclaim retention, andring_workerflood.ring_workerandreminderspassed when rerun alone.coordinator::motorstill fails alone on this Mac, and on lampOS: the second route does a held line's reports_stop and keeps its answer held, as the Live route does, with LAMP_REPORTS=on #1925's branch, where it had passed earlier. ARM64 decides.gh workflow run "lampOS on ARM64" --ref jarvis/route2-checksStill needs lamp time: one real-route trial per feature, through the first builder.