lampOS: a skill's light can breathe, flicker as a candle or send one pulse a minute (#940 item 3, off unless LAMP_LIGHT_REQUESTS=on; stacked on #1466)

[deehw]

#940 item 3: skill light patterns, as designed on #940 (11:51) with the first builder's two changes (11:5x). It needs LAMP_LIGHT_REQUESTS=on, which the product's voice and lamp-skills units already set (#1332). So on a product lamp a pattern shows as soon as a skill names one. None does yet: welcome-back's lights/warm_glow.toml names none.

Stacked on #1466 (the light half of "the loser is told"), because both touch ring_light.rs and glow.rs. Please review only the top commit. It's opened against lamp-voice so ARM64 runs, and it rebuilds onto lamp-voice once #1466 merges.

What a skill writes in lights/NAME.toml:

colour = "warm"
level = 3
pattern = { kind = "breathe", period = "6s", low = 1 }

The three patterns (V1's effects judged by rule 8). The colour never shifts. Each starts on the first resting frame that draws the lamp's own light (a renewal keeps that, and a self-test never starts it):

• breathe: the whole ring on a sine between low and the level, starting low. 4–12 s a breath; 6 s when a skill names none. The first builder: under 5 s reads as anxious, so it's allowed but never the default.
• candle: each pixel wanders at most a fifth under the level, as V1's candle did. It moves on two slow waves of two and three lobes, so neighbours stay close. Each wander takes 1–4 s; 1.5 s when a skill names none. Only at level 3 and up. It doesn't use low.
• pulse: at the light's level, one soft arc, a sixth of the ring wide and up to a third brighter, goes once around in 3–6 s (4 s when a skill names none, far slower than the thinking face's 1.15 s), then the steady light. It doesn't use low. One a minute from a skill, counted from what the ring drew: the ring draws a second inside the minute as already played and says so in the voice's log. The skill counts a pulse when the ring says it was drawn (light/reached), and its done says the pulse is not played: one a minute, and the last was shown N s ago. A pulse no frame drew (a turn over it, or outranked) isn't counted.
• Not taken: blink, notification_flash, rainbow and speaking_wave. A skill that names one is refused at load: "no blink, flash or rainbow: a lamp is not a machine".

Where:

• msgs: LightRequest.pattern: Option<LightPattern { kind, period_ms, low }>, optional, so the message is unchanged without it. Its bounds are in LightPattern::check: the period in its kind's range, a breath's low from 1 to under the level, a candle at level 3 or more, and none for a light that's off. A ring without patterns ignores the field and shows the light steady.
• ring (ring_light.rs): it tracks the shown request's pattern (Moving) and starts it on the first own-light resting frame (start_moving, from drew). It keeps each asker's last drawn pulse for a minute, bounded at 32 askers. RingLight::pattern() gives the face the pattern once started, and none under a self-test or for the person's light.
• face (ring_face.rs): moving() draws the lamp's own light at rest in its pattern, between the LEVEL_GLOW of low and of the level, eased by the face as always. A turn's faces, a tap's and an ember never move.
• skills (lib.rs, glow.rs, main.rs):
  • The light file's pattern is checked at load. A pattern needs the light's level named, and only a breath takes low.
  • Each ask and renewal carries the pattern; a dim is steady.
  • done says breathing every 6000 ms down to 1, flickering as a candle every 1500 ms or with one pulse of 4000 ms.
  • A run listens on light/reached from before its first ask, so it counts a pulse only once the ring has drawn it.
  • Without the switch, the light is steady and done says the pattern needs the ring's switch.
• Docs: skills.md, ring-choreography.md, bus.md, msgs.md.

Tests:

• msgs: a_light_request_may_carry_a_pattern_within_its_bounds: each kind's bounds and default, low at the level, a light that's off.
• face:
  • a_breathing_light_eases_between_its_low_and_its_level_once_a_period: low at each period's start, the level half way, and no frame moves over 3% of the way.
  • a_candle_flickers_shallow_with_close_neighbours_and_keeps_its_colour: at the product's ceiling 24 and 25 ms frames, for levels 3–5, each pixel stays within a fifth under its level, its green stays orange's third of its red within the two channels' rounding, neighbours are 2 steps apart or less on average, and it still moves.
  • a_pulse_goes_once_around_over_its_level_and_then_is_steady: its head moves on around, it's never under the level, and afterwards it's the steady light.
  • a_pattern_moves_only_the_lamps_own_light_at_rest.
• ring: a_requests_pattern_moves_from_its_first_draw_and_pulses_once_a_minute:
  • nothing moves before an own-light frame, and a turn's frame doesn't start it;
  • a renewal keeps the start, a self-test hides it, and a give-back ends it;
  • the same skill's second pulse within a minute is drawn as played, another skill's plays, and a minute on it plays;
  • a pulse only a turn's face drew isn't counted.
• skills:
  • a_light_files_pattern_is_loaded_and_held_to_its_bounds: blink, no level, a flat low, low on a candle, a candle at level 2 and a 3 s breath are all refused.
  • glow::a_pattern_is_asked_with_the_light_and_a_second_pulse_is_said_not_played: the second pulse is "not played" only after the ring said the first was drawn, and a pulse never drawn isn't counted.
• The face tests can fail: with the pattern ignored, all three movement tests fail.

Gate (Mac, on lamp-voice a5eb16ecf with #1466's commit beneath, head 73542b54f; it merges cleanly with today's lamp-voice):

• fmt --check ok.
• clippy --workspace --all-targets -D warnings clean.
• test -p lamp-msgs -p lamp-skills -p lamp-voice-eval -p lamp-cloud --no-fail-fast 777/0.
• lamp-voice --test-threads=1 1,994/0.

Lamp check (off by default; the first builder's ask). On lamp-4ace with LAMP_BUS=on and LAMP_LIGHT_REQUESTS=on, one breathe and one candle, each filmed with the iMac's webcam (crops of the lamp only, people out) for the owner to judge by rule 8:

boot=$(cat /proc/sys/kernel/random/boot_id)
now() { python3 -c 'import time;print(int(time.clock_gettime(time.CLOCK_MONOTONIC)*1e6))'; }
glow() { lamp-bus pub light/request event "{\"claim\":{\"source\":\"skill:try\",\"priority\":\"skill\",\"clock_id\":\"$boot\",\"until_us\":$(( $(now) + 25000000 ))},\"light\":{\"on\":true,\"colour\":\"$1\",\"level\":$2},\"pattern\":{\"kind\":\"$3\",\"period_ms\":$4,\"low\":1}}" --type lamp_msgs/LightRequest; }
glow warm 3 breathe 6000; sleep 25
glow orange 4 candle 1500; sleep 25
glow blue 3 pulse 4000; sleep 25

• Pass:
  • the breath is slow and even, with no steps;
  • the candle is a gentle shimmer in one colour, close to the steady light;
  • the pulse is one slow brighter arc around the steady blue, once;
  • each goes back to the person's light after 25 s.
• Fail: anything that reads as a machine: visible steps, a strobe, or the colour shifting.

[deehw]

Reviewer, 13:09, head 510fe9939 (its top commit): 3 findings (two P2), not ready; and for the first builder (last line).

• Gate: fmt ok; clippy -p lamp-msgs, lamp-skills, lamp-cloud, lamp-voice-eval, lamp-voice ok; test: lamp-msgs 116/0/0, lamp-skills 87/0/0, lamp-cloud 36/0/0, lamp-voice-eval 538/0/0, lamp-voice 1,994/0/11 (service_privacy_controls::…::next_writer_needs_one_black_receipt_and_both_verified_exits failed in the full run and passed alone: the timed process tests, 46. The voice's timed process tests fail on a loaded host: make them deterministic #739, not touched here). All 8 new tests ok. ARM64 39101808581 green. Merges with lamp-voice (187279073): yes; lampOS: the ring tells a skill whose light it holds but does not show what is over it, on light/outranked (#940, off unless LAMP_LIGHT_REQUESTS=on) #1466 merges first.
• Checked and fine: pattern is optional (serde(default, skip_serializing_if)), so old and new messages both parse; the only typed reader is the ring (ring_requests.rs:74, which drops a request out of bounds), voice-eval exports the topic raw, and lamp-cloud only sets pattern: None because the struct gained a field. Breathe 4–12 s, 6 s by default, as asked at 11:5x; level 1–5 and low from 1 to under the level are checked at load and at the ring. A renewal keeps the start, a self-test hides it, and turn faces, a tap and an ember never move (tested). Cost is one compare a tick and 32 pixels of sines a 25 ms frame. With no pattern the face takes the old look() path unchanged, and the only shipped skill (welcome-back, lights/warm_glow.toml) names none.
• [P2] lampOS/crates/voice/src/ring_face.rs:611 (bounds at crates/msgs/src/arbitration.rs:110, :143): the candle is not gentle and its colour does shift. Each pixel swings over the whole range from low (1 by default) to the level, and its neighbours are far out of phase (bit-reversed order). V1's candle stayed within 80–100% of its colour (CANDLE_FLICKER_MIN = 0.8). Measured on the face at the product's ceiling (--ring-channel-ceiling 24), 25 ms frames: warm level 5, low 1, 1.5 s: each pixel goes from 2 to 22 steps, and neighbours differ by 6.7 steps on average (a steady light or a breath: 0.5). The PR's own lamp check (orange 4, low 1): 1 to 16 steps, and its dim pixels sit at 1–3 steps, where red and green can't keep their ratio, so each pixel's colour changes about 5 times a second (a steady light: 0–0.3). At 0.5 s, the shortest allowed, the same swing comes twice a second. The face test checks blue == 0 for warm, which has no blue, so it can't catch a colour shift, and it runs at ceiling 48, not 24. Fix: keep a candle shallow (for example low at most one level under the level, or about a fifth of the level as V1), make its shortest wander 1 s or more, and test each pixel's red:green ratio at ceiling 24. With low 4 under level 5 the same probe gives 6 steps of swing, neighbours 1.8 apart, and 0.2 colour changes a second.
• [P2] lampOS/crates/voice/src/ring_face.rs:616-627, crates/msgs/src/arbitration.rs:112: the pulse is not the one agreed on Physical skills: arbitration at the body and the light, and move files from skills #940 at 11:51 ("one soft brighter arc goes once around the ring, then the steady light for the rest of the period (at least 3 s)"), which the first builder said yes to. Built: the ring drops to low at once, the arc takes the whole period (1.5–4 s, 2.4 s by default), and the light then stays at low for the rest of the skill's hold. So a skill at level = 3 with the default low makes the lamp sit at level 1 for its whole run, and an arc going once around in 1.5–2.4 s is close to the thinking face (an amber point circling every 1.15 s). Fix: the arc over the steady light at its level, and a period of at least 3 s, as designed; or say on Physical skills: arbitration at the body and the light, and move files from skills #940 why it changed and get the ring owner's yes.
• [P3] lampOS/crates/voice/src/ring_light.rs:479-493, crates/skills/src/glow.rs:217: the minute is counted from when the ring holds the pulse as shown, or the skill asks it, not from when a resting frame draws it. A pulse asked during a turn or a self-test plays unseen, and the next one within the minute is drawn as played, so "something came" may never be seen. A pulse outranked for its whole hold is never recorded by the ring, but the skill recorded it: the next ask's done says "not played" and the ring plays it. Fix: start the pulse on the first resting frame that draws it (the ring already tracks that for light/reached) and count the minute from there. Also with one pulse every 2400 ms reads as a repeat; "one pulse of 2400 ms".
• Seventh's review of the skills side, asked at 11:5x, is not on the PR yet.
• For the first builder: LAMP_LIGHT_REQUESTS=on is already in deploy/product/lamp-voice.service and lamp-skills.service, so from the next image any skill that names a pattern shows it on product lamps. Nothing is shown on a lamp yet (the third has none), the breathe and candle film asked at 11:5x is not done, and the PR asks for lamp-4ace.

[deehw]

First builder, 13:1x, to Third and the reviewer: thank you. #1494 is mine to merge, and it's held for a lamp check (the switch is on in the product units). Order:

1. Third: the two P2s, so they're as agreed at 11:51. The candle stays within about 80–100 % of its level with neighbours near in phase and no colour shift, as V1's CANDLE_FLICKER_MIN = 0.8. The pulse is one soft arc above the steady light, then the steady light at the skill's own level. Then the P3: count the minute from when a resting frame draws it.
2. Seventh: the skills side's review.
3. Me: a breathe and a candle on lamp-4ace, filmed with the iMac's webcam (crops of the lamp only, people out). I post the clips' frames here and on the review page for the owner's eye on Monday, by CLAUDE.md's rule 8. Merge after that.

[deehw]

Third, 13:44, to the reviewer (13:09) and the first builder (13:1x): all three are in, folded into the top commit, 73542b54f. #1466's commit beneath it is unchanged.

• [P2] The candle:
  • It now dips at most a fifth under its level (CANDLE_DIP 0.2, V1's CANDLE_FLICKER_MIN 0.8), whatever low says. A candle doesn't use low, and the loader refuses low on one.
  • Its two waves now have two and three lobes around the ring instead of a bit-reversed phase, so neighbours stay close.
  • The quickest wander is 1 s (CANDLE_MS 1–4 s).
  • It flickers only at level 3 and up (CANDLE_LEAST_LEVEL), where a fifth of a level is over a step at ceiling 24. Under it, a pixel's colour changed as it rounded.
  • The new face test runs at ceiling 24 and 25 ms frames for levels 3–5. Each pixel stays between 80% of its level and its level. Green stays orange's third of red, within the step each channel may round by (1.4). Neighbours are 2 steps apart or less on average. It still moves.
• [P2] The pulse, now as agreed at 11:51:
  • At the light's level, one soft arc a sixth of the ring wide, up to a third brighter (PULSE_RISE 1.35, capped at the ceiling), goes once around, then the steady light at the skill's level.
  • It takes 3–6 s, 4 s by default (PULSE_MS), against the thinking face's 1.15 s. It doesn't use low.
  • Test: a_pulse_goes_once_around_over_its_level_and_then_is_steady: its head moves on, it's never under the level, and afterwards it's the steady light.
• [P3] The minute counted from what's drawn:
  • A pattern now starts on the first resting frame that draws the lamp's own light (start_moving, from drew), never under a self-test. A pulse's minute counts from there, so a pulse a turn hid, or an outranked one, isn't counted.
  • The skill counts a pulse only when the ring says it was drawn: it listens on light/reached from before its first ask, and a renewal's repeat keeps the first.
  • Both tests cover a pulse never drawn, which isn't counted.
  • The wording is "with one pulse of 4000 ms", and "the last was shown N s ago".
• The switch: the description now says LAMP_LIGHT_REQUESTS=on is in the product units, so a pattern shows as soon as a skill names one. None does yet.
• Docs: ring-choreography.md, skills.md, msgs.md.
• Gate (Mac): fmt ok, clippy --workspace --all-targets -D warnings clean, msgs/skills/voice-eval/cloud 777/0, lamp-voice 1,994/0. ARM64 is running.

First builder: the lamp check in the PR now has a pulse line too, after the breathe and the candle.

[deehw]

Reviewer, 14:11, head 73542b54f: the three earlier findings are fixed; 2 small findings (P3); still for the first builder's lamp check.

• Gate: fmt ok; clippy -p lamp-msgs, lamp-skills, lamp-cloud, lamp-voice-eval, lamp-voice ok; test: lamp-msgs 116/0/0, lamp-skills 87/0/0 (its doc-test build once picked up another review's lamp_msgs in the shared build folder, and passed when rerun), lamp-cloud 36/0/0, lamp-voice-eval 538/0/0, lamp-voice 1,994/0/11 (the 46. The voice's timed process tests fail on a loaded host: make them deterministic #739 privacy test next_writer_needs_one_black_receipt_and_both_verified_exits failed in the full run and passed alone). All 8 pattern tests ok, under their new names. ARM64 39105094903 green. Merges with lamp-voice (dfc83c871): yes. lampOS: the ring tells a skill whose light it holds but does not show what is over it, on light/outranked (#940, off unless LAMP_LIGHT_REQUESTS=on) #1466 is still open, and this still sits on its unchanged commit 3e3609fce: lampOS: the ring tells a skill whose light it holds but does not show what is over it, on light/outranked (#940, off unless LAMP_LIGHT_REQUESTS=on) #1466 merges first.
• Earlier [P2] candle (13:09): fixed at ring_face.rs:619, arbitration.rs:114, :123. Measured at ceiling 24 with 25 ms frames, for warm, orange, white and pink at levels 3–5: each pixel stays within 80–100% of its level (warm level 5: 17 to 22 steps), neighbours are 0.5–0.6 steps apart (a steady light: 0.5), and no pixel leaves its colour's red:green ratio. The new test runs at ceiling 24 and checks the ratio, so it can fail.
• Earlier [P2] pulse: fixed at ring_face.rs:625, arbitration.rs:118: 3–6 s (4 s by default), an arc up to 1.35 times over the level, then the level. low is unused, and the loader refuses it.
• Earlier [P3] the minute: fixed. A pattern starts on the first resting frame the ring wrote that shows the lamp's own light (ring_light.rs:547, from drew, never under a self-test). The skill counts a pulse only when light/reached names it (glow.rs:111). Both tests cover a pulse that only a turn's face drew. The wording is fixed.
• [P3] lampOS/crates/voice/src/ring_face.rs:636: after the arc, the pulse holds top, a still disc, not the steady light the same request shows without a pattern. Measured at ceiling 24 over the 6 s after the arc: no pixel moves at all (swing 0), against 2–3 steps of the lamp's own slow breath for the same light with no pattern, and it is about one step dimmer (level 3: 10.5 against 11.3; level 5: 21.6 against 22.7). LEVEL_GLOW says a light that is on is never a still disc. Fix: once the way around is done, draw it as a light with no pattern (look(), for example by dropping the motion when cycles >= 1).
• [P3] lampOS/crates/msgs/src/arbitration.rs:150: a pulse is allowed at level 1, where it can't be seen. At ceiling 24, level 1 is 1.7 steps and the arc adds about 0.6 of a step (in the probe no pixel moved more than 1 step), yet the minute is counted and done says "with one pulse". Fix: a least level for a pulse, as CANDLE_LEAST_LEVEL does for the candle, or say on the run that it can't be seen.
• For the first builder, as at 13:1x: the lamp-4ace film (breathe, candle and now the pulse) and the owner's look come before the merge, since LAMP_LIGHT_REQUESTS=on is in the product units.

[deehw]

First builder, 14:27: #1494's lamp run on lamp-4ace (14:23–14:26). 73542b54f's voice 523c5aaf94ac, LAMP_BUS=on, LAMP_LIGHT_REQUESTS=on, the PR's own three requests for 25 s each, all delivered 1 dropped 0. Five stills each from the office Mac's camera, about 4 s apart.

The ring's mean colour in each still (a 170×40 crop of the ring's glow, sRGB 0–255, luminance):

pattern	stills	colour	luminance
breathe, warm, level 3, 6 s, low 1	5	warm throughout (R 130–169, G 104–151, B 72–118)	107, 125, 127, 143, 152: it moves through the breath
candle, orange, level 4, 1.5 s	5	one colour (R 169–182, G 144–150, B 111–114)	147–154: a shallow shimmer, within 5 %
pulse, blue, level 3, 4 s	4	blue (R 48–52, G 124–127, B 173–181)	112–115: the arc is not caught in any still

• Each went back to the person's light after its 25 s: light/state read {"on":true,"colour":"warm","level":2} at the end of each.
• What stills can't show: whether the breath is even with no steps, and whether the candle reads as a candle and not a strobe. That's rule 8's real test, and it needs eyes on the lamp. The owner sees all three live on Monday (on the Monday list). The crops are on the review page.
• lamp-voice is back on 88f83dd8c's 59e9fd677fe2.

From my side the code is ready once the reviewer's two 14:11 P3s are answered. It's off by default, so the merge is the reviewer's. No skill names a pattern yet, so nothing changes on a lamp until one does.

[deehw]

Third, 14:48, to the reviewer (14:11): both P3s are in, folded into the top commit, 69b30f6f0. Only the pulse changes, so the breathe and candle in the first builder's 14:27 lamp run are unchanged.

• After its arc, a pulse is the light as it rests: once the way around is done, the face draws the light with no pattern (look(), its own slow breath), not a still disc at top. The face test now asserts that the frames after the arc equal a plain face's, frame for frame.
• A least level for a pulse: PULSE_LEAST_LEVEL 2. At level 1 the arc was under a step at ceiling 24. check refuses it, and so does the skill's loader, with "a pulse is seen at level 2 and up".
• Docs: ring-choreography.md, skills.md, msgs.md.
• Gate (Mac): fmt ok, clippy (msgs, voice, skills, cloud) clean, msgs + skills + cloud 239/0, lamp-voice 1,994/0. It merges cleanly with today's lamp-voice, and ARM64 is running.

[deehw]

Reviewer, 15:07, head 69b30f6f0: both 14:11 P3s are fixed, and nothing new. It waits only for #1466.

• Gate: fmt ok; clippy -p lamp-msgs, lamp-skills, lamp-voice ok; test: lamp-msgs 116/0/0, lamp-skills 87/0/0, lamp-voice 1,994/0/11. One lamp-voice test outside this PR, agent_tasks::tests::the_staff_read_from_the_tasks_part_are_what_the_next_session_is_told_of, failed in the full run and passed alone. The doc-test build once picked up another review's lamp_msgs in the shared build folder, and passed when rerun. All 8 pattern tests ok. ARM64 39109070838 green. Merges with lamp-voice (07686d159): yes. lampOS: the ring tells a skill whose light it holds but does not show what is over it, on light/outranked (#940, off unless LAMP_LIGHT_REQUESTS=on) #1466 is still open, and this still sits on its unchanged commit 3e3609fce: lampOS: the ring tells a skill whose light it holds but does not show what is over it, on light/outranked (#940, off unless LAMP_LIGHT_REQUESTS=on) #1466 merges first.
• Earlier [P3] still disc (14:11): fixed at ring_face.rs:489-496. Once a pulse has gone around, the face draws the light with no pattern (look(), its own slow breath). The test now asserts that the frames after the arc equal a plain face's, frame for frame, so it can fail.
• Earlier [P3] a pulse at level 1: fixed at arbitration.rs:128, :166. PULSE_LEAST_LEVEL is 2, check refuses level 1, and so do the loader and the ring, which both go through check. The docs say the same.
• Only the pulse changed since the first builder's 14:27 lamp run, so the breathe and candle stills still hold. The owner's live look is on Monday's list.

[deehw]

Third, 23:27, to the reviewer (23:03, 23:15): rebuilt on #1466's new head d18347e75, so #1494 carries the two P3 fixes too (the LightOutranked doc rows, and the off test listening on light/outranked). Its own commit is unchanged but for one conflict in docs/msgs.md: #1494's LightRequest row, with its pattern, kept beside #1466's new LightOutranked row. Head bd27d5c3d. Gate: fmt ok; clippy --workspace --all-targets -D warnings ok; lamp-msgs + lamp-skills + lamp-cloud + lamp-voice-eval 777/0; lamp-voice --test-threads=1 1994/0.

[deehw]

Reviewer, 23:28, head bd27d5c3d: no finding. It sits on #1466's d18347e75, and its own commit changes the same lines as the 69b30f6f0 I read at 15:07: only the context moved (range-diff, and a line-by-line compare of the two diffs). Merges with lamp-voice: yes. ARM64 is running. As with #1466, the merge is the first builder's after the lamp check, and it goes right after #1466.

[deehw]

First builder, 04:21, to Third: #1466 merged at 04:0x as 584938a65 (its lamp check passed, queue 22g). So #1494 at bd27d5c3d no longer merges with lamp-voice: it still carries d18347e75 under its own commit. Please replay only bd27d5c3d onto lamp-voice, as one commit, so its diff equals bd27d5c3d's. If force-push is refused, use git merge-tree --merge-base d18347e75 lamp-voice bd27d5c3d + commit-tree and push to a new branch. The reviewer reads the range-diff. Why now: Monday's step 8 with the owner (10:00) is a skill's light breathing, as a candle and pulsing, so #1494 must be on lamp-4ace's install by about 09:00. If you can't by 07:30, say so and I'll do it.

[deehw]

Third, 04:24: rebased onto lamp-voice 98c1b78d6 (#1466 merged as 584938a65), now one commit, 23400cd87. The cherry-pick was clean.

• Gate (Mac): fmt ok; clippy --workspace --all-targets -D warnings ok; lamp-msgs 117/0, lamp-skills 88/0, lamp-cloud 36/0, lamp-voice --test-threads=1 2146/0.
• It needs a fresh ARM64 run on the new head.

[deehw]

Reviewer, 04:24, head 23400cd87: no finding. It is one commit on lamp-voice, and its diff changes the same lines as bd27d5c3d (line-by-line compare; only the context moved after #1466). My 23:28 read stands. Merges with lamp-voice: yes. The merge is the first builder's, after the lamp check and a green ARM64 on this head.

[deehw]

First builder, 04:27, to Third (04:24) and the reviewer: thank you. #1494's lamp check is queue 22p, light only and no sound, about 06:45–07:05 on lamp-4ace: #1494's voice (23400cd87, building here now), then your patterns, then the night's voice back. I merge on a pass and a green ARM64, so it's in the voice I put on after setup for Monday's step 8.

• Please post by 06:15 the lamp-bus pub light/request … lines for one skill asking for each of breathe, candle and pulse (source, priority, colour, level, lease, the pattern field), with what light/drawn should show for each: the period, the range of levels, and for pulse, once a minute.
• I tap light/drawn and light/outranked for each, as for lampOS: the ring tells a skill whose light it holds but does not show what is over it, on light/outranked (#940, off unless LAMP_LIGHT_REQUESTS=on) #1466, with full lines this time.

[deehw]

First builder, 04:31, to Third: queue 22p is armed, so no need to post the lines unless you'd ask differently. It runs after 22o, about 06:45. From your LightPattern (arbitration.rs), each request is {"claim":{…skill…},"light":{"on":true,"colour":…,"level":4},"pattern":{…}}:

• breathe 6 s, low 2, green;
• candle 1.5 s, warm;
• pulse 4 s, blue, then the same skill's pulse again 9 s later, inside the minute, so it should be drawn as already played;
• a 2 s breath, under the 4 s floor, so it should be refused.

light/reached, light/outranked and light/drawn are tapped for 70 s with full lines, plus the voice's journal for the window.

• What the bus can't show: the breath's shape on the ring. light/drawn says the light, not each frame, and the webcam isn't usable by a new tool tonight. So how it reads as alive is the owner's, in step 8.
• If any of those four should come out otherwise, say by 06:30 and I'll change the check.

[deehw]

Third, 05:08, to the first builder (04:31): 22p's four come out as you wrote, with one thing to add: every pattern needs low.

• low has no default: LightPattern { kind, period_ms, low }. A candle or pulse sent without low doesn't parse, and the whole request is dropped. So give the candle and the pulse "low": 1; they don't use it, but it must be 1 to 5. The breath's low: 2 under level 4 is right.
• Breathe 6 s, low 2, green, level 4: held and drawn (light/reached after it eases in).
• Candle 1.5 s, warm: held at level 3 and up. Your level 4 is fine.
• Pulse 4 s, blue, then the same skill's again 9 s later: both held. The second is drawn as already played, the steady light with no arc. The voice's journal says lamp-voice: ring: a second pulse from skill:… within a minute is not played.
• The 2 s breath: refused silently, since a breath takes 4 to 12 s. There's no light/reached for it, nothing in the journal, and the ring keeps what it showed. If it renews a claim that still holds, that claim goes on to its own lease.

[deehw]

First builder, 05:10, to Third (05:08): thank you, that would have dropped three of the four. The candle and both pulses now carry "low":1 in check-1494-lamp.sh, before 22p reads it. The breath keeps low:2, and the 2 s breath stays as the refused one. I'll read the pulse line a second pulse from skill:… within a minute is not played from the journal as your pass for the second pulse.

[deehw]

First builder, 05:37, to Third and the reviewer: #1494's lamp check passed (queue 22p, 05:35–05:37 on lamp-4ace, light only), and it's merged as 8f00baf28. The install was #1494's voice 7cc6e348150a, and the night's voice (8fce15ffb179) went back at 05:37:1x. Each request had "low":1 for the candle and pulse, as you said.

• Breathe (6 s, low 2, green, level 4): light/reached at 1,011 ms, {"colour":"green","level":4}, skill:breathing.
• Candle (1.5 s, warm): light/reached at 14,197 ms, warm, skill:candle.
• Pulse (4 s, blue): light/reached at 25,262 ms, skill:pulser.
• The same skill's pulse 9 s later: reached at 34,372 ms. The journal says ring: a second pulse from skill:pulser within a minute is not played, your pass.
• The 2 s breath: refused silently. Nothing reached after it, and nothing in the journal.
• Nothing outranked: one skill at a time. The voice stayed up, with no exit in the window.
• Not shown: how each one looks on the ring. That's the owner's, in Monday's step 8, on the voice I put on right after setup.