Skip to content

Fix no colspan on table tempty #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilippGrashoff wants to merge 8 commits into
base: develop
Choose a base branch
from
+1 −0
Open

Fix no colspan on table tempty #2313

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b53bbf
View: remove code executing setModel() if $this->model exists
PhilippGrashoff May 8, 2025
9448990
Revert "View: remove code executing setModel() if $this->model exists"
mvorisek May 11, 2025
08bfb91
add to trait
mvorisek May 12, 2025
8a891aa
Revert "add to trait"
mvorisek May 12, 2025
983e6ad
improve comment
mvorisek May 12, 2025
8ef38d2
Merge remote-tracking branch 'origin/develop' into develop
PhilippGrashoff Apr 30, 2026
d10e0ae
add colspan to tEmpty before rendering it
PhilippGrashoff Apr 30, 2026
d979890
make CS fixer happy
PhilippGrashoff Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ protected function renderView(): void
// add totals rows or empty message
if ($this->_renderedRowsCount === 0) {
if (!$this->jsPaginator || !$this->jsPaginator->getPage()) {
$this->tEmpty->set('columns', (string) count($this->columns));
Copy link
Copy Markdown
Member

@mvorisek mvorisek May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a demo where this can be tested - before and after?

$this->template->dangerouslyAppendHtml('Body', $this->tEmpty->renderToHtml());
}
} elseif ($this->totalsPlan) {
Expand Down
Loading