Fix no colspan on table tempty#2313
Open
PhilippGrashoff wants to merge 8 commits into
Open
Conversation
mvorisek
reviewed
May 12, 2026
| // add totals rows or empty message | ||
| if ($this->_renderedRowsCount === 0) { | ||
| if (!$this->jsPaginator || !$this->jsPaginator->getPage()) { | ||
| $this->tEmpty->set('columns', (string) count($this->columns)); |
Member
There was a problem hiding this comment.
Is there a demo where this can be tested - before and after?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table::tEmpty default Template is:
However, {$columns} was never set, so the always had an empty colspan value. This PR fixes it.