Skip to content

refactor: use exported filterIssues instead of inline logic #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yifanyifan897645 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: use exported filterIssues instead of inline logic #5359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 4 additions & 28 deletions components/dashboard/GoodFirstIssues.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,48 +15,24 @@ interface GoodFirstIssuesProps {
issues: Issue[];
}

/**
* @description Filter issues based on selected repo and area.
*
* @param {Issue[]} issues - The list of issues to filter.
* @param {FiltersType} filters - The filters to apply.
* @returns {Issue[]} The filtered list of issues.
*/
export function filterIssues(issues: Issue[], filters: FiltersType): Issue[] {
let result = issues;

if (filters.selectedRepo !== 'Repository - All') {
if (filters.selectedRepo !== 'All') {
result = result.filter((issue) => issue.repo === filters.selectedRepo);
}
if (filters.selectedArea !== 'Area - All') {
if (filters.selectedArea !== 'All') {
result = result.filter((issue) => issue.area === filters.selectedArea);
}

return result;
}

/**
* @description Component that displays a list of good first issues.
*
* @param {GoodFirstIssuesProps} props - The props for the component.
* @param {Issue[]} props.issues - The list of good first issues.
*/
export default function GoodFirstIssues({ issues }: GoodFirstIssuesProps) {
const [selectedRepo, setSelectedRepo] = useState('All');
const [selectedArea, setSelectedArea] = useState('All');

// Get current issues

let filteredIssues = issues;

const allIssues = issues;

if (selectedRepo !== 'All') {
filteredIssues = filteredIssues.filter((issue) => issue.repo === selectedRepo);
}
if (selectedArea !== 'All') {
filteredIssues = filteredIssues.filter((issue) => issue.area === selectedArea);
}
const filteredIssues = filterIssues(issues, { selectedRepo, selectedArea });

return (
<Table
Expand All @@ -68,7 +44,7 @@ export default function GoodFirstIssues({ issues }: GoodFirstIssuesProps) {
className='ml-auto'
data-testid='GoodFirstIssues-filter-component'
issues={filteredIssues}
allIssues={allIssues}
allIssues={issues}
setSelectedRepo={setSelectedRepo}
setSelectedArea={setSelectedArea}
selectedArea={selectedArea}
Expand Down
Loading