refactor: use exported filterIssues instead of inline logic#5359
refactor: use exported filterIssues instead of inline logic#5359yifanyifan897645 wants to merge 1 commit into
Conversation
The exported filterIssues function was defined but never used, while the
component duplicated its logic inline with inconsistent filter values
('Repository - All' vs 'All'). Fix the filter values to match the
component's usage and replace inline logic with a filterIssues call.
Closes asyncapi#4889
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe issue-filtering logic in GoodFirstIssues is consolidated by centralizing duplicate filtering code into a shared Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5359 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 830 830
Branches 159 159
=========================================
Hits 830 830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5359--asyncapi-website.netlify.app/ |



Summary
filterIssuesfunction filter values from'Repository - All'/'Area - All'to'All'to match the component's actual usageGoodFirstIssuescomponent with a call to the now-consistentfilterIssuesfunctionallIssuesvariable aliasCloses #4889
Summary by CodeRabbit