Conversation
Branch from ariel-os/sbd#68 -- applying only the UART relevant changes.
Branch from ariel-os/sbd#68 -- applying only the UART relevant changes.
Branch from ariel-os/sbd#68 -- applying only the UART relevant changes.
Branch from ariel-os/sbd#68 -- applying only the UART relevant changes.
Branch from ariel-os/sbd#68 -- applying only the UART relevant changes.
Branch from ariel-os/sbd#68 -- applying only the UART relevant changes.
49353aa to
a586226
Compare
|
Rebased, cleaned up, and added a test. Now not based on the problematic #67 series any more. Having this in (and ideally released) would make it practical to turn ariel-os/ariel-os#1613 into a reviewable state. |
ROMemories
left a comment
There was a problem hiding this comment.
I haven't looked at the rest.
Branch from ariel-os/sbd#68 -- applying only the UART relevant changes.
Branch from ariel-os/sbd#68 -- applying only the UART relevant changes.
ROMemories
left a comment
There was a problem hiding this comment.
Generally I think we should have the matching implementation in Ariel OS before landing this.
How? That'd be a chicken-and-egg situation. We can add code in Ariel OS, but that will have dead code until it is also added to the boards, and the boards can't have it until we update which sbd version it uses. There is an open PR that uses it, ariel-os/ariel-os#1613, but that depends on this PR. I think that's the sensible sequence: PR here (done), test in Ariel in that PR (done), merge this, release sbd (it doesn't change output unless one does place the UARTs in the descriptions), merge the Ariel PR (including updated board files, so we never merge untested code). |
|
Rebased onto main; I think all comments are addressed. |
| /// | ||
| /// [hard problem]: https://en.wikipedia.org/wiki/Boolean_satisfiability_problem | ||
| #[serde(default)] | ||
| pub possible_peripherals: Vec<String>, |
There was a problem hiding this comment.
Hm, so this is clearly chip specific meta info. We'll have to move this there (at some point). Let's go with it for now.
This also serves to quickly give the reader of the code an idea of what it is producing.
|
What's the next step? probably a version of ariel-os/ariel-os#1613 with just the uart changes. |
(Built on #67, please ignore the first two commits)
This builds up UARTs to be useful with Ariel OS in a way that avoids the need for
pins.rsin applications (which I think is part of the purpose of board descriptions: to enable generic applications to run on any board, no matter whether the application or the board description is out-of-tree).Concrete changes:
I'm making serde strict. If this is controversial, I'll move it out into another commit, but I think it matters, for Ariel has already started racking up various "alternative syntaxes" for active-high/low. (Those are not cleaned up here yet, just avoiding the issue gets worse)[edit: dropped on reviewer request]has_property, so laze can filter on such a port's presence to decide if an application makese sense to build there.