Skip to content

feat: make schema version separate from schema crate version#139

Merged
kaspar030 merged 1 commit intoariel-os:mainfrom
kaspar030:separate-schema-version
Apr 8, 2026
Merged

feat: make schema version separate from schema crate version#139
kaspar030 merged 1 commit intoariel-os:mainfrom
kaspar030:separate-schema-version

Conversation

@kaspar030
Copy link
Copy Markdown
Member

@kaspar030 kaspar030 commented Mar 30, 2026

#68 changed the schema crate API but technically would not require a breaking version bump. Releaze-plz correctly break bumped the schema crate version as the crate API is breaking.

Before this PR, the schema version was tied to the schema crate version.
This PR unties that.

@kaspar030 kaspar030 force-pushed the separate-schema-version branch from 2a4acc4 to 2092e75 Compare March 30, 2026 09:51
@kaspar030 kaspar030 requested a review from ROMemories March 30, 2026 09:55
@kaspar030 kaspar030 added the enhancement New feature or request label Mar 30, 2026
Comment thread crates/sbd-gen-schema/src/lib.rs
Comment thread crates/sbd-gen-schema/src/lib.rs
Comment thread crates/sbd-gen-schema/src/lib.rs Outdated
@kaspar030 kaspar030 force-pushed the separate-schema-version branch from 2092e75 to 7ed39cd Compare April 8, 2026 09:50
@kaspar030 kaspar030 requested a review from ROMemories April 8, 2026 09:52
Comment thread crates/sbd-gen-schema/src/lib.rs
Comment thread crates/sbd-gen-schema/src/lib.rs Outdated
Signed-off-by: Kaspar Schleiser <kaspar@schleiser.de>
@kaspar030 kaspar030 force-pushed the separate-schema-version branch from 7ed39cd to 90ae680 Compare April 8, 2026 10:27
@kaspar030
Copy link
Copy Markdown
Member Author

This should be an actual constant, not a function, so it shows up in the docs more obviously (that'll be a breaking change, but that's fine for this time).

This is a straight-forward single file change, unblocking others. Why turn it into "for subjectively improved docs, make it a breaking multi-crate change."?

@kaspar030 kaspar030 requested a review from ROMemories April 8, 2026 10:35
@kaspar030 kaspar030 merged commit 6b86c1a into ariel-os:main Apr 8, 2026
3 checks passed
@ROMemories ROMemories mentioned this pull request Apr 9, 2026
@kaspar030 kaspar030 deleted the separate-schema-version branch April 10, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants