Conversation
4170696 to
391423e
Compare
|
hm, I'd like some more control over the breaking/non-breaking here. :/ Technically this is not a breaking schema change (only some new fields added, should be backwards compatible), but it is a breaking schema crate api change. So the version bumps where chosen correctly. It is just that the schema crate now is at 0.4.0, which makes it a breaking change, 0.3.x files are not accepted anymore. Not sure if we want to introduce another version number so we can have separate schema crate and schema file format versions. Maybe that is the easiest - but we'd have to manually manage it. |
391423e to
b9abf7b
Compare
b9abf7b to
a6bc4f6
Compare
Now those are decoupled, we should look into a CI check that ensures a schema (not crate) version breaking change translates into a sbd-gen breaking change. |
|
I think this can be merged. |
ROMemories
left a comment
There was a problem hiding this comment.
Otherwise looks fine, but it would seem like less magic is going on with an actual constant for the schema version.
ROMemories
left a comment
There was a problem hiding this comment.
After some out-of-band discussion, I still think the schema version should be a constant, but for velocity reasons I'm approving the release.
🤖 New release
sbd-gen-schema: 0.3.0 -> 0.4.0 (⚠ API breaking changes)sbd-gen: 0.3.0 -> 0.3.1⚠
sbd-gen-schemabreaking changesChangelog
sbd-gen-schemasbd-genThis PR was generated with release-plz.