Restore functionality of generated Ariel inline modules#67
Open
Restore functionality of generated Ariel inline modules#67
Conversation
Some usages of the generated files are not as standalone Rust files but run through `include!()`, and doc comments do not work there.
Member
Author
|
… and that is still not enough because in those instances, the |
chrysn
changed the title
This reverts some of the late changes to [57] because they would not work for inlined files. [57]: #57 (comment)
chrysn
force-pushed
the
57-for-stable-bis
branch
from
3b7cca8 to
1920dc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some usages of the generated files are not as standalone Rust files but run through
include!(), and doc comments do not work there.This is a follow-up to #57, where in a late change I generalized having the comment everywhere rather than just in a single place. As a comment-only change, I did not test that in full. (I did re-test the rustfmt aspects in #65, but not only by manually reproducing the comment's effect, not on a full Ariel build).