Skip to content

fix: address rmcp DNS rebinding advisory #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaleSeo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: address rmcp DNS rebinding advisory #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bfc4ed
fix: address rmcp DNS rebinding advisory
DaleSeo Apr 29, 2026
56dcde1
docs: note rmcp host validation behavior change
DaleSeo Apr 29, 2026
85a96ef
chore: install jwks from crates.io
DaleSeo May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/bump_rmcp_for_dns_rebinding_advisory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
default: patch
---

# Bump `rmcp` to 1.6 to address DNS rebinding advisory

Updates the `rmcp` Streamable HTTP server transport to 1.6.0, which patches [GHSA-89vp-x53w-74fx](https://github.com/modelcontextprotocol/rust-sdk/security/advisories/GHSA-89vp-x53w-74fx) (CVE-2026-42559). Host header validation is now performed inside `rmcp` itself, with a `tracing::warn!` event on each rejection so log-based alerting on DNS rebinding attempts continues to work; the server's existing `transport.streamable_http.host_validation` configuration is unchanged.
11 changes: 6 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ insta = { version = "1.43.1", features = [
"yaml",
"glob",
] }
rmcp = { version = "1.2", features = [
rmcp = { version = "1.6", features = [
"server",
"transport-io",
"transport-streamable-http-server",
Expand Down
2 changes: 1 addition & 1 deletion crates/apollo-mcp-server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ http = "1.3.1"
humantime-serde = "1.1.1"
jsonschema = "0.42.0"
jsonwebtoken = { version = "10.3", features = ["rust_crypto"] }
jwks = { git = "https://github.com/chenhunghan/jwks", tag = "v0.5.3" }
jwks = "0.5.3"
Copy link
Copy Markdown
Member Author

@DaleSeo DaleSeo May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JWKS v0.5.3 was published on crates.io so this git workaround is no longer needed.

lz-str = "0.2.1"
opentelemetry = "0.31.0"
opentelemetry-otlp = { version = "0.31.0", features = [
Expand Down
Loading
Loading