Skip to content

fix: address rmcp DNS rebinding advisory#742

Open
DaleSeo wants to merge 3 commits intomainfrom
AMS-492
Open

fix: address rmcp DNS rebinding advisory#742
DaleSeo wants to merge 3 commits intomainfrom
AMS-492

Conversation

@DaleSeo
Copy link
Copy Markdown
Member

@DaleSeo DaleSeo commented Apr 29, 2026

Bumps rmcp from 1.2 to 1.6 to pull in the fix for GHSA-89vp-x53w-74fx (CVE-2026-42559). With 1.6, host validation is enforced inside the Streamable HTTP transport, so the custom axum middleware we used to layer on top is no longer needed.

@DaleSeo DaleSeo self-assigned this Apr 29, 2026
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian Bot commented Apr 29, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* (developer-tools)/apollo-mcp-server/(latest)/config-file.mdx

Build ID: 6da2b8faec3cb8cdfc68f49d
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/6da2b8faec3cb8cdfc68f49d


⚠️ AI Style Review — 1 Issue Found

Summary

The pull request updates the documentation style guide with three key changes: the 'framing-apollo-products' section now recommends the word 'use' over 'using' for a more direct tone; the 'framing' section emphasizes active voice and reader-centric positioning to clarify responsibility; and the 'word-and-symbol-usage' section specifies using 'enabled' instead of 'allowed' when describing feature-based functionality or permissions.

Duration: 2467ms
Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@DaleSeo DaleSeo force-pushed the AMS-492 branch 4 times, most recently from c7d464d to 1f20be4 Compare April 30, 2026 17:38
@DaleSeo DaleSeo marked this pull request as ready for review April 30, 2026 17:40
@DaleSeo DaleSeo requested review from a team as code owners April 30, 2026 17:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Changeset file added - thank you!

<Note>

Host validation is only available when using the `streamable_http` transport. Localhost addresses (`localhost`, `127.0.0.1`, `::1`, `0.0.0.0`) are always allowed when validation is enabled.
Host validation is only available when using the `streamable_http` transport. Loopback addresses (`localhost`, `127.0.0.1`, `::1`) are always allowed when validation is enabled.
Copy link
Copy Markdown
Member Author

@DaleSeo DaleSeo Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped 0.0.0.0 to match the Rust SDK implementation. It only serves as a bind sentinel, meaning it listens on every interface, not as a destination. When a real client connects to a server bound to 0.0.0.0, it resolves through a real interface and sends that in the Host header. The previous in-tree validator's check for is_loopback() || is_unspecified() mixed up the bind-side and destination-side semantics. The TypeScript and Go MCP SDKs also follows the same implementation.

Comment thread .changeset/bump_rmcp_for_dns_rebinding_advisory.md Outdated
@DaleSeo DaleSeo marked this pull request as draft May 1, 2026 13:17
@DaleSeo
Copy link
Copy Markdown
Member Author

DaleSeo commented May 1, 2026

I'm converting this to a draft. I noticed that rcmp doesn't emit tracing events. I put out a fix upstream in modelcontextprotocol/rust-sdk#826. We'll upgrade it to v1.6 instead.

jsonschema = "0.42.0"
jsonwebtoken = { version = "10.3", features = ["rust_crypto"] }
jwks = { git = "https://github.com/chenhunghan/jwks", tag = "v0.5.3" }
jwks = "0.5.3"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JWKS v0.5.3 was published on crates.io so this git workaround is no longer needed.

@DaleSeo DaleSeo marked this pull request as ready for review May 1, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant