Skip to content

Fix : disk space and file descriptor leaks in ChangelogStreamHandleReaderWithCache #27969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manishnemade12 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix : disk space and file descriptor leaks in ChangelogStreamHandleReaderWithCache #27969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ...dfs/src/main/java/org/apache/flink/changelog/fs/ChangelogStreamHandleReaderWithCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ private RefCountedFile downloadToCacheFile(FileStateHandle fileHandle) {

return new RefCountedFile(file);
} catch (IOException e) {
LOG.warn("Failed to download cache file. Deleting partially downloaded file {}", file.getPath(), e);
if (!file.delete()) {
LOG.warn("Could not delete partially downloaded cache file {}", file.getPath());
}
ExceptionUtils.rethrow(e);
return null;
}
Expand All @@ -152,11 +156,16 @@ private RefCountedFile downloadToCacheFile(FileStateHandle fileHandle) {
private FileInputStream openAndSeek(RefCountedFile refCountedFile, long offset)
throws IOException {
FileInputStream fin = new FileInputStream(refCountedFile.getFile());
if (offset != 0) {
LOG.trace("seek to {}", offset);
fin.getChannel().position(offset);
try {
if (offset != 0) {
LOG.trace("seek to {}", offset);
fin.getChannel().position(offset);
}
return fin;
} catch (Exception e) {
IOUtils.closeQuietly(fin);
throw e;
}
return fin;
}

private DataInputStream wrapStream(Path dfsPath, FileInputStream fin) {
Expand Down