Fix : disk space and file descriptor leaks in ChangelogStreamHandleReaderWithCache#27969
Open
Manishnemade12 wants to merge 1 commit intoapache:masterfrom
Open
Fix : disk space and file descriptor leaks in ChangelogStreamHandleReaderWithCache#27969Manishnemade12 wants to merge 1 commit intoapache:masterfrom
Manishnemade12 wants to merge 1 commit intoapache:masterfrom
Conversation
… on seek errors in ChangelogStreamHandleReaderWithCache
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes severe disk space and file descriptor leaks in
ChangelogStreamHandleReaderWithCachethat occur during filesystem or network errors.Previously, if a network cluster error disrupted DFS stream copying in
downloadToCacheFile, the partially transferred temporary cache file was permanently left on disk, eventually causing disk full crashes on TaskManagers. Furthermore, ifopenAndSeekthrew anIOExceptionduring channel positioning, the instantiatedFileInputStreamwas leaked without being closed, exhausting OS file handles.Brief change log
file.delete()on the target temporary block whenIOExceptionis encountered during DFS buffer copying indownloadToCacheFile.fin.getChannel().position(offset)inside atry-catchblock underopenAndSeekwhich guaranteesIOUtils.closeQuietly(fin)is triggered if positioning fails, preventing unclosed file streams.Verifying this change
This change is already covered by existing tests, such as standard Changelog State Backend recovery tests that implicitly test file system operations and DFS stream caching logic.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation