Skip to content

CASSANDRA-21574 Fix failing tests for TrackerReconcilerTest #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcapwell merged 2 commits into from
Aug 19, 2026
+7 −1
Merged

CASSANDRA-21574 Fix failing tests for TrackerReconcilerTest #288

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb3acef
fix
alanwang67 Aug 13, 2026
6dcf60e
fixes
alanwang67 Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion accord-core/src/test/java/accord/coordinate/tracking/FastPathTrackerReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void validate(RequestStatus status)

case Success:
Assertions.assertTrue(tracker.all(FastPathShardTracker::hasReachedQuorum));
Assertions.assertTrue(tracker.all(shard -> shard.fastPathIsRejected() || shard.hasMetFastPathCriteria() || shard.fastPathIsDelayed()));
Assertions.assertTrue(tracker.all(shard -> shard.hasMetFastPathCriteria() || (shard.fastPathFailures + shard.fastPathDelayed > 0) || shard.fastPathIsRejected() || shard.fastPathIsDelayed()));

@dcapwell dcapwell Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Assertions.assertTrue(tracker.all(shard -> shard.hasMetFastPathCriteria() || (shard.fastPathFailures + shard.fastPathDelayed > 0) || shard.fastPathIsRejected() || shard.fastPathIsDelayed()));
Assertions.assertTrue(tracker.all(shard -> shard.hasMetFastPathCriteria() || shard.fastPathIsRejected() || shard.fastPathIsDelayed() || (shard.fastPathFailures + shard.fastPathDelayed > 0)));

Reordering the assert order made it harder to validate what changed in the diff

@dcapwell dcapwell Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also explain why (shard.fastPathFailures + shard.fastPathDelayed > 0)?

so we check: met fast path, fast path is rejected, fast path is delayed... so your check just says "at least 1 failure or delay exists"? can you explain the situation you found and why this is the right fix?

Assertions.assertFalse(tracker.any(FastPathShardTracker::hasFailed));
break;

Expand Down
5 changes: 5 additions & 0 deletions accord-core/src/test/java/accord/topology/TopologyRandomizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,11 @@ private boolean validToReassignRange(Topology current, Shard[] nextShards, Map<I

private boolean previousEpochForRegainedRangeRetired(Topology current, Ranges regainingRanges)
{
// In cases where nodeLookup is null, we are not testing invariants that are

@dcapwell dcapwell Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't feel this comment helps. It didn't really tell me anything so I had to walk the code to understand why its there.

What i see is that 2 code paths set null and one sets nodeMap:::get... The 2 code paths that set null do not create Node so we don't have the metadata needed to do this check...

We could have a comment like this?

When nodeLookup isn't defined we are unable to get node state, so assume that the calling test doesn't care about retired ranges

// related to this logic
if (this.nodeLookup == null)
return true;

for (Id id : current.nodes())
{
Node node = this.nodeLookup.apply(id);
Expand Down