Skip to content

CASSANDRA-21574 Fix failing tests for TrackerReconcilerTest #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanwang67 wants to merge 2 commits into
base: trunk
Choose a base branch
from
+7 −1
Open

CASSANDRA-21574 Fix failing tests for TrackerReconcilerTest #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb3acef
fix
alanwang67 Aug 13, 2026
6dcf60e
fixes
alanwang67 Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion accord-core/src/test/java/accord/coordinate/tracking/FastPathTrackerReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ void validate(RequestStatus status)

case Success:
Assertions.assertTrue(tracker.all(FastPathShardTracker::hasReachedQuorum));
Assertions.assertTrue(tracker.all(shard -> shard.fastPathIsRejected() || shard.hasMetFastPathCriteria() || shard.fastPathIsDelayed()));
// Covers the conditions which allow Success to be returned in FastPathTracker.java
Assertions.assertTrue(tracker.all(shard -> shard.fastPathIsRejected() || shard.hasMetFastPathCriteria() || shard.fastPathIsDelayed() || (shard.fastPathFailures + shard.fastPathDelayed > 0)));
Assertions.assertFalse(tracker.any(FastPathShardTracker::hasFailed));
break;

Expand Down
5 changes: 5 additions & 0 deletions accord-core/src/test/java/accord/topology/TopologyRandomizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,11 @@ private boolean validToReassignRange(Topology current, Shard[] nextShards, Map<I

private boolean previousEpochForRegainedRangeRetired(Topology current, Ranges regainingRanges)
{
// When nodeLookup isn't defined we are unable to get node state, so
// assume that the calling test doesn't care about retired ranges
if (this.nodeLookup == null)
return true;

for (Id id : current.nodes())
{
Node node = this.nodeLookup.apply(id);
Expand Down