Skip to content

fix: IVF GNO-IMI build fails recall threshold #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vsag-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+46 −0
Open

fix: IVF GNO-IMI build fails recall threshold #2744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/algorithm/ivf/gno_imi_partition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,15 @@ GNOIMIPartition::ClassifyDatas(const void* datas,
int64_t count,
BucketIdType buckets_per_data,
QueryContext* ctx) const {
Vector<float> norm_vectors(allocator_);
if (metric_type_ == MetricType::METRIC_TYPE_COSINE) {
norm_vectors.resize(count * dim_);
for (int64_t i = 0; i < count; ++i) {
Normalize(
static_cast<const float*>(datas) + i * dim_, norm_vectors.data() + i * dim_, dim_);
}
datas = norm_vectors.data();
}
Vector<BucketIdType> result(buckets_per_data * count, this->allocator_);
inner_joint_classify_datas(
reinterpret_cast<const float*>(datas), count, buckets_per_data, result.data(), ctx);
Expand Down
37 changes: 37 additions & 0 deletions src/algorithm/ivf/gno_imi_partition_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,43 @@ TEST_CASE("GNO-IMI Partition Basic Test", "[ut][GNOIMIPartition]") {
std::cout << "match count(first_order_scan_ratio=1.0): " << match_count << std::endl;
}

TEST_CASE("GNO-IMI cosine build routing is scale invariant", "[ut][GNOIMIPartition]") {
constexpr int64_t dim = 32;
constexpr int64_t data_count = 512;
auto allocator = SafeAllocator::FactoryDefaultAllocator();
IndexCommonParam param;
param.dim_ = dim;
param.metric_ = MetricType::METRIC_TYPE_COSINE;
param.allocator_ = allocator;
auto strategy_param = std::make_shared<IVFPartitionStrategyParameters>();
strategy_param->FromJson(JsonType::Parse(R"({
"partition_strategy_type": "gno_imi",
"ivf_train_type": "kmeans",
"gno_imi": {
"first_order_buckets_count": 4,
"second_order_buckets_count": 4
}
})"));
auto partition = std::make_unique<GNOIMIPartition>(param, strategy_param);

auto vectors = fixtures::generate_vectors(data_count, dim, false, 95);
auto dataset = Dataset::Make();
dataset->Float32Vectors(vectors.data())->Dim(dim)->NumElements(data_count)->Owner(false);
partition->Train(dataset);

auto normalized_vectors = vectors;
for (int64_t i = 0; i < data_count; ++i) {
Normalize(normalized_vectors.data() + i * dim, normalized_vectors.data() + i * dim, dim);
}
auto raw_result = partition->ClassifyDatas(vectors.data(), data_count, 1, nullptr);
auto normalized_result =
partition->ClassifyDatas(normalized_vectors.data(), data_count, 1, nullptr);
for (uint64_t i = 0; i < raw_result.size(); ++i) {
CAPTURE(i);
REQUIRE(raw_result[i] == normalized_result[i]);
}
}

TEST_CASE("GNO-IMI Partition Serialize Test", "[ut][GNOIMIPartition]") {
auto allocator = SafeAllocator::FactoryDefaultAllocator();
int64_t dim = 128;
Expand Down
Loading