Skip to content

fix: IVF GNO-IMI build fails recall threshold - #2744

Open
vsag-bot wants to merge 1 commit into
antgroup:mainfrom
vsag-bot:codex/ai-fix-2743-a97758ff
Open

fix: IVF GNO-IMI build fails recall threshold#2744
vsag-bot wants to merge 1 commit into
antgroup:mainfrom
vsag-bot:codex/ai-fix-2743-a97758ff

Conversation

@vsag-bot

Copy link
Copy Markdown
Collaborator

Summary

GNO-IMI now applies consistent cosine normalization during training, build/add routing, and search routing. A deterministic scale-invariance regression covers the failure mechanism.

Root Cause

GNO-IMI normalized cosine vectors during training and query routing but classified raw base vectors during build/add. This violated cosine scale invariance, assigned vectors to inconsistent buckets, and could lower recall below the functional-test threshold.

Changes

  • Normalize cosine vectors before GNOIMIPartition build/add bucket classification.
  • Add a fixed-seed unit test verifying identical routing for raw and normalized cosine vectors.

Validation

  • pre-fix scale-invariance regression: passed - Reproduced different bucket assignments before applying the production fix.
  • cmake --build build-ai-fix-local --target unittests --parallel 4: passed - Affected library and unit tests built successfully.
  • unittests "[GNOIMIPartition]": passed - All 3 test cases and 9 assertions passed.
  • unittests "GNO-IMI cosine build routing is scale invariant": passed - All 512 routing assertions passed.
  • functests "(PR) IVF GNO-IMI Build": passed - All 38,620 assertions passed.
  • clang-format-15 --dry-run --Werror; git diff --check: passed - No formatting or whitespace errors.
  • clang-tidy-15: not_run - clang-tidy 15 is unavailable in this environment.

Residual Risks

  • The full ASan suite and exact stochastic CI matrix were not run locally; the deterministic regression directly covers the normalization defect.
  • The unrelated recoverable MemoryIO UBSan diagnostics reported in CI were not addressed.

Base branch: main

Fixes #2743

Prepared by vsag-bot after automatic effort ordering and AI repairability preflight.

Signed-off-by: vsag-bot <276218163+vsag-bot@users.noreply.github.com>
Assisted-by: Codex:gpt-5.6-sol
@vsag-bot vsag-bot added the created-by-AI The issue is found and created by AI Agent label Aug 21, 2026
@vsag-bot
vsag-bot requested a review from jiaweizone as a code owner August 21, 2026 10:47
@vsag-bot vsag-bot added the kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 label Aug 21, 2026
@vsag-bot

Copy link
Copy Markdown
Collaborator Author

/label status/waiting-for-review
/waiting-on reviewer
/request-review @jiaweizone
/request-review @wxyucs
/request-review @inabao
/request-review @LHT129

@vsag-bot vsag-bot added the status/waiting-for-ci Waiting for CI; the AI agent handles failures label Aug 21, 2026
@vsag-bot vsag-bot self-assigned this Aug 21, 2026
@vsag-bot

vsag-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

AI PR state: status/waiting-for-review
Current owner: @wxyucs
Reason: human approval is required
Head: 67bdb93

Automatic merging is disabled. A maintainer performs the final merge.

@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 3 merge protections satisfied — ready to merge.

Show 3 satisfied protections

🟢 Require kind label

  • label~=^kind/

🟢 Require version label

  • label~=^version/

🟢 Require linked issue for feature/bug PRs

  • body~=(?im)(?:^|[\s\-\*])(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s*:?\s+(?:#\d+|[\w.\-]+/[\w.\-]+#\d+|https?://github\.com/[\w.\-]+/[\w.\-]+/issues/\d+)

@vsag-bot vsag-bot added status/waiting-for-review Waiting for maintainer review and removed status/waiting-for-ci Waiting for CI; the AI agent handles failures labels Aug 21, 2026
@vsag-bot vsag-bot assigned wxyucs and unassigned vsag-bot Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by-AI The issue is found and created by AI Agent kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 size/M status/waiting-for-review Waiting for maintainer review version/1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug](ci): IVF GNO-IMI build fails recall threshold

2 participants